Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload DICOM images with FTPS #226

Merged
merged 45 commits into from
Jan 23, 2024
Merged

Upload DICOM images with FTPS #226

merged 45 commits into from
Jan 23, 2024

Conversation

milanmlft
Copy link
Member

@milanmlft milanmlft commented Jan 16, 2024 •
edited
Loading

  • Adds upload_dicom_image() in pixl_core to export DICOM images over FTPS to the DSH
  • DICOM images are exported as a .zip file to <project_slug>/<pseudo_anon_identifier>.zip
  • Adds a test FTP server Docker container to mock an FTPS server for testing

Fixes #190

stefpiatek and others added 14 commits January 12, 2024 10:49
@milanmlft milanmlft marked this pull request as ready for review January 22, 2024 17:27
@milanmlft milanmlft requested a review from stefpiatek January 23, 2024 09:25
stefpiatek
stefpiatek reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Need to make some changes for it to work in production

orthanc/orthanc-anon/plugin/pixl.py Outdated Show resolved Hide resolved
orthanc/orthanc-anon/plugin/pixl.py Outdated Show resolved Hide resolved
pixl_core/src/core/_database.py Outdated Show resolved Hide resolved
pixl_core/src/core/_database.py Outdated Show resolved Hide resolved
pixl_core/src/core/upload.py Outdated Show resolved Hide resolved
pixl_core/tests/conftest.py Outdated Show resolved Hide resolved
pixl_core/tests/conftest.py Outdated Show resolved Hide resolved
pixl_core/tests/conftest.py Outdated Show resolved Hide resolved
pixl_core/tests/conftest.py Outdated Show resolved Hide resolved
pixl_core/tests/test_upload.py Outdated Show resolved Hide resolved
stefpiatek
stefpiatek approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this in 🎉

Happy for you to merge, some small suggestions remaining I think

orthanc/orthanc-anon/plugin/pixl.py Outdated Show resolved Hide resolved
@milanmlft milanmlft enabled auto-merge (squash) January 23, 2024 17:00
@milanmlft milanmlft merged commit f204c5e into main Jan 23, 2024
8 checks passed
@milanmlft milanmlft deleted the stef/image-upload-sftp branch January 23, 2024 17:05
This was referenced Jan 25, 2024
Open
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefpiatek stefpiatek stefpiatek approved these changes

@ruaridhg ruaridhg Awaiting requested review from ruaridhg

Assignees

@ruaridhg ruaridhg

@milanmlft milanmlft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export DICOM images via FTPS
3 participants
@milanmlft @stefpiatek @ruaridhg