Start documenting design choices #574
Open
+391
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #574 +/- ##
=======================================
Coverage 87.38% 87.38%
=======================================
Files 76 76
Lines 3386 3386
=======================================
Hits 2959 2959
Misses 427 427 ☔ View full report in Codecov by Sentry. |
milanmlft
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Looking really nice 👌
Wonder if it's worth adding a record for the export API? From memory I seem to recall there was some back and forth on how to approach this as well, as we needed something flexible that can handle multiple destinations on a per-project basis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually documenting design choices. Hopefully a reasonable summary of what the options considered were, at least in the last year or so.
What else have I missed?
Reckon there'll be a lot so up for other suggestions of decisions that we've made that are worth noting