Skip to content

MQTT over websocket is no longer supported #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

MQTT over websocket is no longer supported #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ The following are the known available endpoints:

| CMD param | ENV variable | Description |
|-----------------------------------|---------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| -m or --mqtt-uri | MQTT_URI | URI to the MQTT Server. TCP: tcp://mqtt.eclipseprojects.io:1883, WebSocket: ws://mqtt.eclipseprojects.io:9001 or TLS: tls://mqtt.eclipseprojects.io:8883 - Leave it empty to disable MQTT connection |
| -m or --mqtt-uri | MQTT_URI | URI to the MQTT Server. TCP: tcp://mqtt.eclipseprojects.io:1883 or TLS: tls://mqtt.eclipseprojects.io:8883 - Leave it empty to disable MQTT connection |
| --mqtt-server-cert | MQTT_SERVER_CERT | Path to the server certificate authority file in PEM format is required for TLS |
| --mqtt-server-cert-check-hostname | MQTT_SERVER_CERT_CHECK_HOSTNAME | Enable or disable TLS certificate hostname checking when using a custom certificate. Enabled (True) by default. Set to False when using a self-signed certificate without a matching hostname. This option might be insecure. |
| --mqtt-user | MQTT_USER | MQTT user name |
Expand Down
1 change: 0 additions & 1 deletion src/configuration/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ def __init__(self, transport_mechanism: str, with_tls: bool) -> None:
self.with_tls = with_tls

TCP = "tcp", False
WS = "websockets", False
TLS = "tcp", True


Expand Down
2 changes: 0 additions & 2 deletions src/configuration/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,6 @@ def __parse_mqtt_transport(args: Namespace, config: Configuration) -> None:
parse_result = urllib.parse.urlparse(args.mqtt_uri)
if parse_result.scheme == "tcp":
config.mqtt_transport_protocol = TransportProtocol.TCP
elif parse_result.scheme == "ws":
config.mqtt_transport_protocol = TransportProtocol.WS
elif parse_result.scheme == "tls":
config.mqtt_transport_protocol = TransportProtocol.TLS
if args.tls_server_cert_path:
Expand Down
1 change: 0 additions & 1 deletion src/publisher/mqtt_publisher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ def __init__(self, configuration: Configuration) -> None:

mqtt_client = gmqtt.Client(
client_id=str(self.publisher_id),
transport=self.transport_protocol.transport_mechanism,
will_message=gmqtt.Message(
topic=self.get_topic(mqtt_topics.INTERNAL_LWT, False),
payload="offline",
Expand Down