Fixes #579 buildWithBaseURLPath return only last part of url

[joelpittet]

The array_pop() assumes the last part of the path is the only valid leading an invalid_response error:

"The response was received at https://example.com/sub-directory/acs instead of https://example.com/sub-directory/saml/acs"

[joelpittet]

This should help fix #579

[RoSk0]

@joelpittet this change breaks the functionality when self::getBaseURLPath() == /

[joelpittet]

@RoSk0 Are you certain it worked before? Or are you suggesting that my change didn’t account for another edge case? In what scenario would a URL be just /?

I think I’m following what you’re saying based on this test, but I’m still unclear on when / would be used as a URL. Could you provide more context on that scenario?
https://3v4l.org/p86qT

[RoSk0]

I've applied the patch from that commit to the project with composer-patches and run a debugger . I saw my /saml2/IDP/acs request URI turned into saml2IDPacs

…

On Wed, 25 Sept 2024, 16:52 Joel Pittet, ***@***.***> wrote: @RoSk0 <https://github.com/RoSk0> Are you certain it worked before? Or are you suggesting that my change didn’t account for another edge case? In what scenario would a URL be just /? I think I’m following what you’re saying based on this test, but I’m still unclear on when / would be used as a URL. Could you provide more context on that scenario? https://3v4l.org/p86qT — Reply to this email directly, view it on GitHub <#581 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA5DWKK7QIV7QHA3ERQ5Q3ZYI6SVAVCNFSM6AAAAABE4E57YOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZSHE2TSMZVGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[pitbulk]

@RoSk0 I think I covered here the case where getBaseURLPath() == /

Can you provide more info on the issue you are experiencing?

Please share the URL, the relevant values on $_SERVER, the expected and what you are getting.

is maybe a config problem on the server configuration?