Fix WantAuthnRequestsSigned parser. #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitbulk
force-pushed
the
master
branch
2 times, most recently
from
4fa3934
to
acef8eb
Compare
bitti
reviewed
Feb 20, 2023
| want_authn_requests_signed = entity_descriptor_node.get('WantAuthnRequestsSigned', None) | ||
| want_authn_requests_signed = idp_descriptor_node.get('WantAuthnRequestsSigned', None) |
There was a problem hiding this comment.
Note that this causes a regression, because idp_descriptor_node.get('WantAuthnRequestsSigned', None) returns the string 'false' for my config (and probably others as well) which gets later evaluated to True in
python3-saml/src/onelogin/saml2/settings.py
Line 480 in 538622d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #306