Fix WantAuthnRequestsSigned parser #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bitti can you confirm this is what you were expecting? |
I'm sorry for the late reply. I tested it today and it's working fine! Will the fix be included in the next release? It doesn't seem the failing test is related to the change at all? I wonder though if a regression test should be added for this issue. But maybe that's already implied by the changed expectations? (Which expect a boolean now instead of literal |
bitti
approved these changes
Mar 29, 2023
iherasymenko
approved these changes
Apr 5, 2023
|
@pitbulk wondering if you have a moment to merge this and release a new version. Thanks! |
|
We're also waiting on a new release here. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.