Fix Java weirdness

SAML-Toolkits · Aug 18, 2021 · a35e8bc · a35e8bc
1 parent ea4b078
commit a35e8bc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/test/response_test.rb b/test/response_test.rb
@@ -1141,6 +1141,9 @@ def generate_audience_error(expected, actual)
       end
 
       it "optionally allows for clock drift on NotOnOrAfter" do
+        # Java Floats behave differently than MRI
+        java = %w[jruby truffleruby].include?(ENV['RUBY_ENGINE'])
+
         settings.soft = true
 
         # The NotBefore condition in the document is 2011-06-1418:31:01.516Z
@@ -1154,7 +1157,7 @@ def generate_audience_error(expected, actual)
 
           special_response_with_saml2_namespace = OneLogin::RubySaml::Response.new(
               response_document_with_saml2_namespace,
-              :allowed_clock_drift => 0.484
+              :allowed_clock_drift => java ? 0.485 : 0.484
           )
           assert special_response_with_saml2_namespace.send(:validate_conditions)
 
@@ -1167,7 +1170,7 @@ def generate_audience_error(expected, actual)
 
           special_response_with_saml2_namespace = OneLogin::RubySaml::Response.new(
               response_document_with_saml2_namespace,
-              :allowed_clock_drift => '0.484'
+              :allowed_clock_drift => java ? '0.485' : '0.484'
           )
           assert special_response_with_saml2_namespace.send(:validate_conditions)
         end

diff --git a/test/slo_logoutrequest_test.rb b/test/slo_logoutrequest_test.rb
@@ -185,6 +185,9 @@ class RubySamlTest < Minitest::Test
       end
 
       it "optionally allows for clock drift" do
+        # Java Floats behave differently than MRI
+        java = %w[jruby truffleruby].include?(ENV['RUBY_ENGINE'])
+
         logout_request.soft = true
         logout_request.document.root.attributes['NotOnOrAfter'] = '2011-06-14T18:31:01.516Z'
 
@@ -193,13 +196,13 @@ class RubySamlTest < Minitest::Test
           logout_request.options[:allowed_clock_drift] = 0.483
           assert !logout_request.send(:validate_not_on_or_after)
 
-          logout_request.options[:allowed_clock_drift] = 0.484
+          logout_request.options[:allowed_clock_drift] = java ? 0.485 : 0.484
           assert logout_request.send(:validate_not_on_or_after)
 
           logout_request.options[:allowed_clock_drift] = '0.483'
           assert !logout_request.send(:validate_not_on_or_after)
 
-          logout_request.options[:allowed_clock_drift] = '0.484'
+          logout_request.options[:allowed_clock_drift] = java ? '0.485' : '0.484'
           assert logout_request.send(:validate_not_on_or_after)
         end
       end