Remove ruby 2.4+ warnings #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitbulk
reviewed
May 29, 2018
lib/onelogin/ruby-saml/response.rb
Outdated
| @@ -288,7 +289,7 @@ def issuers | |||
| raise ValidationError.new(error_msg) | |||
| end | |||
|
|
|||
| doc = decrypted_document.nil? ? document : decrypted_document | |||
| _doc = decrypted_document.nil? ? document : decrypted_document | |||
There was a problem hiding this comment.
Can you remove this line? It seems not required.
pitbulk
reviewed
May 29, 2018
lib/onelogin/ruby-saml/utils.rb
Outdated
| @@ -32,7 +32,9 @@ def self.format_cert(cert) | |||
| formatted_cert.join("\n") | |||
| else | |||
| cert = cert.gsub(/\-{5}\s?(BEGIN|END) CERTIFICATE\s?\-{5}/, "") | |||
| cert = cert.gsub(/[\n\r\s]/, "") | |||
| cert = cert.gsub(/[\r]/, "") | |||
| cert = cert.gsub(/\n/, "") | |||
There was a problem hiding this comment.
/\n/ or /[\n]/ ?
/\s/ or /[\s]/ ?
pitbulk
reviewed
May 29, 2018
lib/xml_security.rb
Outdated
| @@ -318,10 +318,10 @@ def validate_signature(base64_cert, soft = true) | |||
|
|
|||
| # check digests | |||
| ref = REXML::XPath.first(sig_element, "//ds:Reference", {"ds"=>DSIG}) | |||
| uri = ref.attributes.get_attribute("URI").value | |||
| _uri = ref.attributes.get_attribute("URI").value | |||
There was a problem hiding this comment.
Can you remove this line as well?
|
I commit the fix. Should I squash it into one commit? |
|
I think we are ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do some code refactor in order to remove warnings about unused variables, inner scoped variables with same name of outer scope and a missing initialization of
@loggerinstance attribute inside Logger. I don't change any code behaviour.