Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed version (Cython==0.28.2) not usefull #71

Closed
guettli opened this issue Jul 23, 2018 · 1 comment
Closed

Fixed version (Cython==0.28.2) not usefull #71

guettli opened this issue Jul 23, 2018 · 1 comment

Comments

@guettli
Copy link
Contributor

guettli commented Jul 23, 2018

The version of Cython is fixed to 0.28.2.

I use 0.28.4

I think fixing the version that strict is not useful.

I am sure 0.28.4 is valid, too.

Here is the exception I get:

===> pip install -e git+https://github.com/SAP/PyRFC.git#egg=pyrfc
Obtaining pyrfc from git+https://github.com/SAP/PyRFC.git#egg=pyrfc
  Updating ./src/pyrfc clone
    Complete output from command python setup.py egg_info:
    Couldn't find index page for 'Sphinx' (maybe misspelled?)
    warning: no files found matching 'TODO'
    no previously-included directories found matching 'doc/_build'
    
    Installed /home/u/p/pyrfc-env/src/pyrfc/.eggs/Sphinx-1.3.1-py2.7.egg
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/home/u/p/pyrfc-env/src/pyrfc/setup.py", line 89, in <module>
        test_suite='pyrfc',
      File "/usr/lib/python2.7/distutils/core.py", line 111, in setup
        _setup_distribution = dist = klass(attrs)
      File "/home/u/p/pyrfc-env/local/lib/python2.7/site-packages/setuptools/dist.py", line 269, in __init__
        self.fetch_build_eggs(attrs['setup_requires'])
      File "/home/u/p/pyrfc-env/local/lib/python2.7/site-packages/setuptools/dist.py", line 313, in fetch_build_eggs
        replace_conflicting=True,
      File "/home/u/p/pyrfc-env/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 826, in resolve
        dist = best[req.key] = env.best_match(req, ws, installer)
      File "/home/u/p/pyrfc-env/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 1085, in best_match
        dist = working_set.find(req)
      File "/home/u/p/pyrfc-env/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 695, in find
        raise VersionConflict(dist, req)
    pkg_resources.VersionConflict: (Cython 0.28.4 (/home/u/p/pyrfc-env/lib/python2.7/site-packages), Requirement.parse('Cython==0.28.2'))

@bsrdjan
Copy link
Contributor

bsrdjan commented Jul 24, 2018

thanks, you are right, will remove the restriction. Per experience so far, new Cython version has never been a problem and no need to keep it fixed.

bsrdjan added a commit that referenced this issue Jul 31, 2018
@bsrdjan bsrdjan closed this as completed Jul 31, 2018
bsrdjan added a commit that referenced this issue Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants