Skip to content
This repository has been archived by the owner on May 24, 2023. It is now read-only.

Add terser as option to minify js #153

Merged
merged 7 commits into from
May 28, 2020
Merged

Add terser as option to minify js #153

merged 7 commits into from
May 28, 2020

Conversation

CarlosOrozco88
Copy link
Contributor

@CarlosOrozco88 CarlosOrozco88 commented May 19, 2020

Adds js compression with terser. By default all existing configurations will use uglifyjs.

https://github.com/terser/terser
Why choose terser?
uglify-es is no longer maintained and uglify-js does not support ES6+.

terser is a fork of uglify-es that mostly retains API and CLI compatibility with uglify-es and uglify-js@3

@CLAassistant
Copy link

CLAassistant commented May 19, 2020

CLA assistant check
All committers have signed the CLA.

@matz3
Copy link
Contributor

matz3 commented May 27, 2020

Thanks for your work! I think we could even replace uglify with terser, which would make both API and the plugin code less verbose.
We also did that in the ui5-builder project a while ago and did not encounter any issues so far: SAP/ui5-builder#305

@matz3 matz3 added the enhancement New feature or request label May 27, 2020
Copy link
Contributor

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, apart from some minor things.

README.md Outdated Show resolved Hide resolved
Gruntfile.js Show resolved Hide resolved
@matz3 matz3 merged commit 8c525ba into SAP-archive:master May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants