Skip to content

Commit

Permalink
fix(addon): cancel by c++ thread instead of nodejs thread
Browse files Browse the repository at this point in the history
Segfaults were possible under conditions described in related issue

BREAKING CHANGE: cancel() method removed at addon level, remains on client and pool level

fix #234
  • Loading branch information
bsrdjan committed Mar 23, 2022
1 parent fac9378 commit 2f1777b
Show file tree
Hide file tree
Showing 19 changed files with 119 additions and 89 deletions.
2 changes: 1 addition & 1 deletion lib/wrapper/cancel.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions lib/wrapper/noderfc-bindings.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ export interface NWRfcBinding {
environment: NodeRfcEnvironment;
setIniFileDirectory(iniFileDirectory: string): any | undefined;
loadCryptoLibrary(libAbsolutePath: string): any | undefined;
cancel(client: {
connectionHandle: number;
functionHandle?: number;
}, callback?: Function): any | undefined;
verbose(): this;
}
declare let noderfc_binding: NWRfcBinding;
Expand Down
2 changes: 1 addition & 1 deletion lib/wrapper/noderfc-bindings.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion lib/wrapper/sapnwrfc-client.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ export interface RfcClientBinding {
close(callback: Function): void;
resetServerContext(callback: Function): void;
ping(callback: Function): void;
cancel(callback: Function): void;
invoke(rfmName: string, rfmParams: RfcObject, callback: Function, callOptions?: RfcCallOptions): void;
release(oneClientBinding: [RfcClientBinding], callback: Function): void;
}
Expand All @@ -94,7 +95,7 @@ export declare class Client {
open(callback?: Function): void | Promise<Client>;
ping(callback?: Function): void | Promise<boolean>;
close(callback?: Function): void | Promise<void>;
cancel(callback?: Function): void | Promise<any>;
cancel(callback?: Function): void | Promise<void>;
resetServerContext(callback?: Function): void | Promise<void>;
release(callback?: Function): void | Promise<void>;
call(rfmName: string, rfmParams: RfcObject, callOptions?: RfcCallOptions): Promise<RfcObject>;
Expand Down
24 changes: 21 additions & 3 deletions lib/wrapper/sapnwrfc-client.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/wrapper/sapnwrfc-client.js.map

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions lib/wrapper/sapnwrfc-pool.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/wrapper/sapnwrfc-pool.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 2f1777b

Please sign in to comment.