Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update table-groupings-d344c5a.md #123

Merged
merged 1 commit into from
May 15, 2024
Merged

Update table-groupings-d344c5a.md #123

merged 1 commit into from
May 15, 2024

Conversation

sani2608
Copy link
Contributor

typo fix

Copy link

cla-assistant bot commented May 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented May 10, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@OlMue OlMue added contribution Valuable Contribution type/spelling-grammar The spelling or grammar is wrong. SAP Fiori elements labels May 13, 2024
Copy link

sap-doc-bot bot commented May 13, 2024

Thank you for your valuable content contribution, @sani2608! So that we can recognize your contribution in the SAP Community, please check your SAP Community user ID (this is a number) in your personal settings page and share it with us in a reply to this comment. Make sure you just include the number in the reply.

Your user ID is displayed as follows:

Change display name for User ID N

where N is your user ID. For example, 53 is the user ID of the user 'qmacro'.

Please note that we are currently refactoring our profile and badge system on the SAP Community, and will start assigning badges again when that's complete.

@OlMue
Copy link
Contributor

OlMue commented May 13, 2024

Hi @sani2608, thanks for your contribution! We're on it.

@sani2608
Copy link
Contributor Author

Thank you for your valuable content contribution, @sani2608! So that we can recognize your contribution in the SAP Community, please check your SAP Community user ID (this is a number) in your personal settings page and share it with us in a reply to this comment. Make sure you just include the number in the reply.

Your user ID is displayed as follows:

Change display name for User ID N

where N is your user ID. For example, 53 is the user ID of the user 'qmacro'.

Please note that we are currently refactoring our profile and badge system on the SAP Community, and will start assigning badges again when that's complete.

831978

@KaijaInga
Copy link
Contributor

Hi @sani2608 , the changes have been made, you can see them on Help Portal: https://help.sap.com/docs/SAPUI5/96880755e4e64fcd96c12694f430fece/d344c5aa5c81483482dbbed5b3abb142.html?state=DRAFT&q=table%20groupings
Please check if everything's alright on your end and let me know if there's anything else we should check. If not, please close this pull request. Thank you!

@OlMue
Copy link
Contributor

OlMue commented May 14, 2024

@KaijaInga, thanks! Just to let you know: Contributors from outside SAP can't access the draft Help Portal link you provided.

Since you corrected the typo, you can now merge this PR. external contributors don't have this authorization, and merging is the last step if we have accepted a contribution. Thanks! :-)

@KaijaInga
Copy link
Contributor

Thanks, @OlMue ! I can't merge, though...
image

@OlMue OlMue merged commit e91c998 into SAP-docs:main May 15, 2024
6 checks passed
@OlMue
Copy link
Contributor

OlMue commented May 15, 2024

Hi @KaijaInga, right, I need to check your authorizations, sorry. I merged the PR in the meantime.

@sani2608 sani2608 deleted the patch-1 branch May 16, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution SAP Fiori elements type/spelling-grammar The spelling or grammar is wrong.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants