Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: star is not a valid ts expression for an import #129

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

o-liver
Copy link
Contributor

@o-liver o-liver commented Jun 5, 2024

This is not the only place where star (*) is used for the import. When I have this star VS Code tells me: "Expression expected.ts(1109)"

Copy link

cla-assistant bot commented Jun 5, 2024

CLA assistant check
All committers have signed the CLA.

@KvM2
Copy link
Contributor

KvM2 commented Jun 5, 2024

Hi @o-liver, thanks for your contribution! We'll look into it and will get back to you.

@KlattG KlattG added the contribution Valuable Contribution label Jun 5, 2024
Copy link

sap-doc-bot bot commented Jun 5, 2024

Thank you for your valuable content contribution, @o-liver! So that we can recognize your contribution in the SAP Community, please check your SAP Community user ID (this is a number) in your personal settings page and share it with us in a reply to this comment. Make sure you just include the number in the reply.

Your user ID is displayed as follows:

Change display name for User ID N

where N is your user ID. For example, 53 is the user ID of the user 'qmacro'.

Please note that we are currently refactoring our profile and badge system on the SAP Community, and will start assigning badges again when that's complete.

@KlattG KlattG added size/s Requires minimal effort to get changed. type/examples-samples Related to existing examples/samples, or request for new examples/samples. labels Jun 5, 2024
@o-liver
Copy link
Contributor Author

o-liver commented Jun 5, 2024

843769

@KlattG
Copy link
Contributor

KlattG commented Jun 18, 2024

Hi @o-liver , please take a second to sign our CLA, so we can properly acknowledge your contribution for the SAP Community. Thanks!

@o-liver
Copy link
Contributor Author

o-liver commented Jun 18, 2024

Hi @o-liver , please take a second to sign our CLA, so we can properly acknowledge your contribution for the SAP Community. Thanks!

done

@KlattG KlattG merged commit e08e555 into SAP-docs:main Jun 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution size/s Requires minimal effort to get changed. type/examples-samples Related to existing examples/samples, or request for new examples/samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants