Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify content density handling with Fiori Launchpad in more details #172

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Specify content density handling with Fiori Launchpad in more details #172

wants to merge 12 commits into from

Conversation

ulasenka
Copy link

No description provided.

@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Nov 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Nov 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KvM2
Copy link
Contributor

KvM2 commented Nov 19, 2024

Hi @ulasenka , thanks for your contribution! We'll look into it and will get back to you.

@KlattG KlattG added follow-up-with/dev Clarification with development needed. in-discussion This item is being discussed internally labels Dec 18, 2024
KlattG
KlattG reviewed Dec 19, 2024
View reviewed changes
docs/03_Get-Started/step-36-content-density-d935dbf.md
@@ -10,7 +10,7 @@ In this step of our Walkthrough tutorial, we adjust the content density based on



**The content density is compact on desktop devices and cozy on touch-enabled devices**
**The default content density is cozy on touch devices (smartphones, tablets and computers with a touch screen) and compact on devices without a touch screen. Note that Fiori Launchpad sets cozy content density on phones and tablets as mandatory and may override it on other computers according to the application manifest and the user preference.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulasenka Is there a reason why this only is added for the JavaScript text but not to the TypeScript step?

@KlattG KlattG requested review from margopolo, petermuessig and flovogt and removed request for petermuessig and margopolo December 19, 2024 15:35
@KlattG
Copy link
Contributor

KlattG commented Dec 20, 2024

@margopolo @petermuessig The Walkthrough tutorials demonstrate how to build a standalone app, so there is no outer shell like the SAP Fiori launchpad that could have set the content density class already. What do you think - should we leave the Walkthroughs as they are then? Or should we mention in the text that care needs to be taken if an app is embedded in the FLP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KlattG KlattG KlattG left review comments

@flovogt flovogt Awaiting requested review from flovogt

@petermuessig petermuessig Awaiting requested review from petermuessig

@margopolo margopolo Awaiting requested review from margopolo

Assignees

@KlattG KlattG

Labels
follow-up-with/dev Clarification with development needed. in-discussion This item is being discussed internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ulasenka @KvM2 @KlattG @petermuessig @margopolo