Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update creating-a-simple-square-control-9a6100b.md #51

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

dexter0175
Copy link
Contributor

No description provided.

@cla-assistant
Copy link

cla-assistant bot commented Apr 9, 2023

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Apr 9, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KvM2
Copy link
Contributor

KvM2 commented Apr 11, 2023

Hi @dexter0175 , thanks for your contribution. We appreciate it and will look into this.

@KvM2 KvM2 self-assigned this Apr 11, 2023
@boghyon
Copy link
Contributor

boghyon commented Apr 18, 2023

Good catch! The current renderer definition there is indeed syntactically wrong which could be fixed with this PR. It would be better if at least apiVersion: 2 or apiVersion: 4 could be added to the renderer object.

Without the explicit apiVersion 2 or higher, the control will be rendered string-based bypassing the efficient DOM-patching: SAP/openui5-docs#33


Generally, the UI5 rendering topic is a mess at the moment. See the "Motivation" section at SAP/openui5-docs#17. But that's a different issue..

@KvM2
Copy link
Contributor

KvM2 commented May 23, 2023

Thanks for your patience - I will get back to you on this.

@KvM2 KvM2 assigned KlattG and unassigned KvM2 May 30, 2023
@KlattG KlattG merged commit 66b8b8a into SAP-docs:main Jun 6, 2023
@sap-doc-bot sap-doc-bot bot added the contribution Valuable Contribution label Jun 6, 2023
@sap-doc-bot
Copy link

sap-doc-bot bot commented Jun 6, 2023

Thank you for your valuable content contribution, @dexter0175! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

@KlattG
Copy link
Contributor

KlattG commented Jun 6, 2023

Hi @dexter0175 , thanks for your contribution. The issue will be fixed with UI5 1.115

@OlMue OlMue added the type/examples-samples Related to existing examples/samples, or request for new examples/samples. label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution type/examples-samples Related to existing examples/samples, or request for new examples/samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants