Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DC Mission 3252 (Kyma) for QAS #265

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Update DC Mission 3252 (Kyma) for QAS #265

merged 4 commits into from
Jul 18, 2024

Conversation

markusbalsam
Copy link
Contributor

Purpose

Update DC Mission 3252 (Kyma) for QAS

  • auto-select kyma region if kyma instance parameters are not set
  • update Readme
  • add outputs.tf
  • add custom_idp
  • rename kyma variables
  • add validation

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Documentation content changes
[x] Other... Please describe: Update DC Mission 3252 (Kyma) for QAS

@markusbalsam
auto-select kyma-region if params not provided
f438e46 
+ update Readme
+ add outputs.tf
+ add custom_idp
+ rename kyma variables
+ add validation
@markusbalsam
Update README.md
0bb9115
@rui1610 rui1610 self-requested a review July 18, 2024 13:07
@rui1610
Update provider.tf
63c4d69 
Remove comment that is not needed
rui1610
rui1610 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@rui1610 rui1610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just removed one comment in the provider.tf file.

rui1610
rui1610 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@rui1610 rui1610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rui1610 rui1610 merged commit 22d58c3 into SAP-samples:main Jul 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rui1610 rui1610 rui1610 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markusbalsam @rui1610