Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No projection #401

Merged
merged 4 commits into from
Nov 28, 2024
Merged

No projection #401

merged 4 commits into from
Nov 28, 2024

Conversation

agoerler
Copy link
Contributor

No description provided.

@agoerler agoerler requested a review from etimr November 26, 2024 13:51
@agoerler agoerler changed the base branch from main to feature-tree-table November 26, 2024 13:52
NodeProperty: node_id, // identifies a node
ParentNavigationProperty: parent // navigates to a node's parent
NodeProperty: ID, // identifies a node
ParentNavigationProperty: parnt // navigates to a node's parent
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a bug, which prevents us to use parent as name for the parent association

name : localized String(255);
descr : localized String(1000);
parent : Association to one Genres on parent.node = parent_node;
parnt : Association to Genres;
children : Composition of many Genres
Copy link
Contributor

@etimr etimr Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a composition of many here? At the end we want to have a foreign key in the db table which is the result of parnt : Association to Genres;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a composition of many here? At the end we want to have a foreign key in the db table which is the result of parnt : Association to Genres;

It's already there on main. I kept it to minimize the delta to main. But I'm also fine with removing it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've missed that it's already in main. You are right, we don't need to make any additional changes, that are not relevant for us.

@agoerler agoerler merged commit cd01357 into feature-tree-table Nov 28, 2024
1 check passed
@agoerler agoerler deleted the noProjection branch November 28, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants