Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more genres #412

Merged
merged 8 commits into from
Dec 17, 2024
Merged

more genres #412

merged 8 commits into from
Dec 17, 2024

Conversation

eugene-andreev
Copy link
Contributor

@eugene-andreev eugene-andreev commented Dec 10, 2024

Inspired by https://shinywords.com/book-genres/

Warning! This may break the tests!

@eugene-andreev eugene-andreev marked this pull request as draft December 10, 2024 11:55
@agoerler
Copy link
Contributor

Warning! This may break the tests!

Well, then adjust the test ...

@agoerler
Copy link
Contributor

agoerler commented Dec 10, 2024

Hier sind noch ein paar: https://en.wikipedia.org/wiki/List_of_writing_genres#Fiction_genres

Z.B.

  • Fiction
    • Science Fiction
      • Utopian and Dystopian
        • Dystopian
          • Cyberpunk
            • Steampunk

@eugene-andreev
Copy link
Contributor Author

Warning! This may break the tests!

Well, then adjust the test ...

This is planned, as soon, as Olena is ready with her changes. We decided that she merges her changes first

@agoerler agoerler marked this pull request as ready for review December 17, 2024 15:54
@agoerler agoerler merged commit 333d2da into feature-tree-table Dec 17, 2024
1 check passed
@agoerler agoerler deleted the feature-tree-table-more-genres branch December 17, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants