feat : Enable custom version release #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newtork
reviewed
Oct 24, 2024
| @@ -57,7 +58,7 @@ def bump_version( | |||
| ) | |||
|
|
|||
| updated_versions: dict[str, str] = self._bump_versions( | |||
| current_versions, bump_type | |||
| current_versions, bump_type, custom_version | |||
There was a problem hiding this comment.
(Minor)
Not ideal argument namings with combined current_versions: dict[str,str] and current_version: str, requires the reader/maintainer to look it up first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Allows providing a custom version while releasing a new version of the library.
Feature Scope
Definition of Done
[ ] Feature scope is documented[ ] Release notes are created