Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Added webhook check for workload name on CAV #123

Merged
merged 4 commits into from
Sep 6, 2024
Merged

[Misc] Added webhook check for workload name on CAV #123

merged 4 commits into from
Sep 6, 2024

Conversation

anirudhprasad-sap
Copy link
Contributor

@anirudhprasad-sap anirudhprasad-sap commented Sep 5, 2024 •
edited
Loading

  1. Workload name check
  2. tenant Id label and validity check on CAPTenantOutput on create and update

Pavan-SAP

This comment was marked as outdated.

Sign in to view

Pavan-SAP

This comment was marked as duplicate.

Sign in to view

@Pavan-SAP Pavan-SAP dismissed their stale review September 6, 2024 06:13

update needed

Pavan-SAP
Pavan-SAP reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@Pavan-SAP Pavan-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.. minor issue with operation for cap tenant output

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@anirudhprasad-sap anirudhprasad-sap merged commit f52a332 into main Sep 6, 2024
7 checks passed
@anirudhprasad-sap anirudhprasad-sap deleted the workloadNameCheck branch September 6, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pavan-SAP Pavan-SAP Pavan-SAP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anirudhprasad-sap @Pavan-SAP