Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] added version monitoring for cleanup #132

Merged
merged 10 commits into from
Sep 25, 2024
Merged

[FEAT] added version monitoring for cleanup #132

merged 10 commits into from
Sep 25, 2024

Conversation

skrishnan-sap
Copy link
Contributor

@skrishnan-sap skrishnan-sap commented Sep 17, 2024

CHANGES:

  • CAPApplicationVersion enhanced with
    • deletion rules based on metric rules or PromQL expression
    • scrape configuration
  • New routine to periodically collect relevant versions and queue them for evaluation
  • New routine to process queued versions by evaluating metrics rules
  • added service monitor creation for workload services based on scrape configuration
  • website/documentation update
    • added documentation about version monitoring
    • updated docsy version

Resources for testing:

@skrishnan-sap skrishnan-sap changed the title [FEAT] added version cleanup monitoring [FEAT] added version monitoring for cleanup Sep 17, 2024
- `CAPApplicationVersion` enhanced with
  - deletion rules based on metric rules or PromQL expression
  - scrape configuration
- New routine to periodically collect relevant versions and queue them for evaluation
- New routine to process queued versions by evaluating metrics rules
- added service monitor creation for workload services based on scrape configuration
Pavan-SAP and others added 7 commits September 20, 2024 14:22
- update to the latest version
- log Warning when no servicemonitor CRD exists
- added a LogWarning method to the util to keep logs consistent
CHANGES:
- updated `hugo` modules
- enabled dark mode support (from `docsy`)
- added page related to version monitoring
- generated relevat API Reference docs and Helm chart docs

---------

Co-authored-by: Pavan <pavan.nayak@sap.com>
Copy link
Contributor

@Pavan-SAP Pavan-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@skrishnan-sap skrishnan-sap merged commit 963c666 into main Sep 25, 2024
7 checks passed
@skrishnan-sap skrishnan-sap deleted the vers-mon branch September 25, 2024 09:02
Pavan-SAP added a commit that referenced this pull request Sep 25, 2024
CHANGES:
- `CAPApplicationVersion` enhanced with
  - deletion rules based on metric rules or PromQL expression
  - scrape configuration
- New routine to periodically collect relevant versions and queue them
for evaluation
- New routine to process queued versions by evaluating metrics rules
- added service monitor creation for workload services based on scrape
configuration
- website/documentation update
  - added documentation about version monitoring
  - added what's new page
  - updated `docsy` version with dark mode support

Co-authored-by: Pavan <25031267+Pavan-SAP@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants