generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] added version monitoring for cleanup #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrishnan-sap
changed the title
[FEAT] added version cleanup monitoring
[FEAT] added version monitoring for cleanup
Sep 17, 2024
- `CAPApplicationVersion` enhanced with - deletion rules based on metric rules or PromQL expression - scrape configuration - New routine to periodically collect relevant versions and queue them for evaluation - New routine to process queued versions by evaluating metrics rules - added service monitor creation for workload services based on scrape configuration
skrishnan-sap
force-pushed
the
vers-mon
branch
from
September 17, 2024 16:44
75d72f9
to
2a3049c
Compare
- update to the latest version - log Warning when no servicemonitor CRD exists - added a LogWarning method to the util to keep logs consistent
CHANGES: - updated `hugo` modules - enabled dark mode support (from `docsy`) - added page related to version monitoring - generated relevat API Reference docs and Helm chart docs --------- Co-authored-by: Pavan <pavan.nayak@sap.com>
Pavan-SAP
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Pavan-SAP
reviewed
Sep 25, 2024
Quality Gate passedIssues Measures |
Pavan-SAP
added a commit
that referenced
this pull request
Sep 25, 2024
CHANGES: - `CAPApplicationVersion` enhanced with - deletion rules based on metric rules or PromQL expression - scrape configuration - New routine to periodically collect relevant versions and queue them for evaluation - New routine to process queued versions by evaluating metrics rules - added service monitor creation for workload services based on scrape configuration - website/documentation update - added documentation about version monitoring - added what's new page - updated `docsy` version with dark mode support Co-authored-by: Pavan <25031267+Pavan-SAP@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES:
CAPApplicationVersion
enhanced withdocsy
versionResources for testing:
ghcr.io/skrishnan-sap/cap-operator/controller:sha-ad5c711