Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Enabled JSON Logs & Added/Enhanced structured logs #77

Merged
merged 6 commits into from
May 24, 2024

Conversation

anirudhprasad-sap
Copy link
Contributor

No description provided.

@anirudhprasad-sap

This comment was marked as outdated.

@anirudhprasad-sap

This comment was marked as resolved.

@Pavan-SAP

This comment was marked as resolved.

@anirudhprasad-sap anirudhprasad-sap marked this pull request as ready for review April 29, 2024 07:15
anirudhprasad-sap and others added 5 commits May 24, 2024 11:55
…tifierHash in existing logs

update to latest state
Added more logs depicting tenant operation flow
Use zapr based JSON logging in controller
Switch server, web-hook and deprecated mtx-job to also use JSON logger
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
70.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Contributor

@Pavan-SAP Pavan-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed conditions 70.7% Coverage on New Code (required ≥ 80%)

We do not have tests for main.go files. as these mainly just have the setup parts! (will ignore these files from sonar in a seperate change)

@Pavan-SAP Pavan-SAP changed the title [Misc] Added/Enhanced structured logs [Misc] Enabled JSON Logs & Added/Enhanced structured logs May 24, 2024
@anirudhprasad-sap anirudhprasad-sap merged commit 2846327 into main May 24, 2024
6 of 7 checks passed
@anirudhprasad-sap anirudhprasad-sap deleted the logging branch May 24, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants