Draft Release 4: Basic Changes #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metrics are no longer supported by this library. You can utilize the OpenTelemetry Java Agent extension to ship metrics via OTLP. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
Jersey instrumentation is no longer supported. Since the sample app uses this feature it is removed as well. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
Replace javax.servlet classes with jakarta only support. This breaks the current Spring Boot sample app. It will be migrated to Spring Boot 3.x in a later step. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
Build the entire project with Java 11 to prepare for Java 17. Some components already were built with 11, this is now aligned throughout the entire code base. The animal sniffer plugin was dropped in the process.
Upgrades Logback and Log4j to latests versions. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
Remove references to custom metrics, Java 8 and javax.servlet. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
Replace JUnit dependency and introduce Assert4J. Migrate core tests to new frameworks. Remove Hamcrest. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
Adaptations to Spring Security 6 Basic Authentication. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
nicklas-dohrn
approved these changes
Mar 27, 2024
| "\"version\":\"92720bd3-2735-489d-bf4b-e5bb05c752e7\" " + | ||
| "}"; | ||
| public static final String VCAP_APPLICATION = | ||
| "{" + "\"application_id\":\"" + VCAP_APP_ID + "\", " + "\"application_name\":\"" + VCAP_APP_NAME + "\", " + "\"application_uris\":[ " + "\"testapp.testdomain.com\" " + "], " + "\"application_version\":\"92720bd3-2735-489d-bf4b-e5bb05c752e7\", " + "\"cf_api\":\"https://api.cf.sap.hana.ondemand.com\", " + "\"host\":\"0.0.0.0\", " + "\"instance_id\":\"34b12c70-5443-426f-75c4-3260\", " + "\"instance_index\":\"" + VCAP_INSTANCE_IDX + "\", " + "\"limits\":{ " + "\"disk\":1024, " + "\"fds\":16384, " + "\"mem\":1024 " + "}, " + "\"name\":\"d048888-logging-sample-app\", " + "\"organization_id\":\"" + VCAP_ORGANIZATION_ID + "\", " + "\"organization_name\":\"" + VCAP_ORGANIZATION_NAME + "\", " + "\"port\":8080, " + "\"process_id\":\"a6026141-8d69-4e9d-b62d-8e1d982f7953\", " + "\"process_type\":\"web\", " + "\"space_id\":\"" + VCAP_SPACE_ID + "\", " + "\"space_name\":\"" + VCAP_SPACE_NAME + "\", " + "\"uris\":[ " + "\"testapp.testdomain.com\" " + "], " + "\"version\":\"92720bd3-2735-489d-bf4b-e5bb05c752e7\" " + "}"; | ||
|
|
There was a problem hiding this comment.
what is the benefit of "onelining" all this fields?
There was a problem hiding this comment.
No benefit. Automatic code-formatting.
| <email>martin.nikolov@sap.com</email> | ||
| <organization>SAP SE</organization> | ||
| <organizationUrl>https://github.com/SAP</organizationUrl> | ||
| </developer> |
There was a problem hiding this comment.
some people are missing here, for example christian dinse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR on the way to #164. It contains the following major changes:
javax.servletsupport in favour of Jakarta