Skip to content

Fix Dynatrace Exported to Generate DELTA Temporality #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fix Dynatrace Exported to Generate DELTA Temporality #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 39 additions & 17 deletions ...sap/hcf/cf/logging/opentelemetry/agent/ext/exporter/DynatraceMetricsExporterProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import io.pivotal.cfenv.core.CfService;

import java.time.Duration;
import java.util.Locale;
import java.util.function.Function;
import java.util.logging.Logger;

Expand Down Expand Up @@ -46,20 +47,39 @@ private static Duration getTimeOut(ConfigProperties config) {
return timeout != null ? timeout : config.getDuration("otel.exporter.dynatrace.timeout");
}

private static AggregationTemporalitySelector getAggregationTemporalitySelector(ConfigProperties config) {
String temporalityStr = config.getString("otel.exporter.dynatrace.metrics.temporality.preference");
if (temporalityStr == null) {
return AggregationTemporalitySelector.deltaPreferred();
}
AggregationTemporalitySelector temporalitySelector;
switch (temporalityStr.toLowerCase(Locale.ROOT)) {
case "cumulative":
return AggregationTemporalitySelector.alwaysCumulative();
case "delta":
return AggregationTemporalitySelector.deltaPreferred();
case "lowmemory":
return AggregationTemporalitySelector.lowMemory();
default:
throw new ConfigurationException("Unrecognized aggregation temporality: " + temporalityStr);
}
}

private static DefaultAggregationSelector getDefaultAggregationSelector(ConfigProperties config) {
String defaultHistogramAggregation =
config.getString("otel.exporter.dynatrace.metrics.default.histogram.aggregation");
if (defaultHistogramAggregation == null) {
return DefaultAggregationSelector.getDefault().with(InstrumentType.HISTOGRAM, Aggregation.defaultAggregation());
return DefaultAggregationSelector.getDefault()
.with(InstrumentType.HISTOGRAM, Aggregation.defaultAggregation());
}
if (AggregationUtil.aggregationName(Aggregation.base2ExponentialBucketHistogram())
.equalsIgnoreCase(defaultHistogramAggregation)) {
return
DefaultAggregationSelector.getDefault()
.with(InstrumentType.HISTOGRAM, Aggregation.base2ExponentialBucketHistogram());
.equalsIgnoreCase(defaultHistogramAggregation)) {
return DefaultAggregationSelector.getDefault().with(InstrumentType.HISTOGRAM,
Aggregation.base2ExponentialBucketHistogram());
} else if (AggregationUtil.aggregationName(explicitBucketHistogram())
.equalsIgnoreCase(defaultHistogramAggregation)) {
return DefaultAggregationSelector.getDefault().with(InstrumentType.HISTOGRAM, Aggregation.explicitBucketHistogram());
.equalsIgnoreCase(defaultHistogramAggregation)) {
return DefaultAggregationSelector.getDefault()
.with(InstrumentType.HISTOGRAM, Aggregation.explicitBucketHistogram());
} else {
throw new ConfigurationException(
"Unrecognized default histogram aggregation: " + defaultHistogramAggregation);
Expand All @@ -83,16 +103,19 @@ public MetricExporter createExporter(ConfigProperties config) {
return NoopMetricExporter.getInstance();
}

LOG.info("Creating metrics exporter for service binding " + cfService.getName() + " (" + cfService.getLabel() + ")");
LOG.info(
"Creating metrics exporter for service binding " + cfService.getName() + " (" + cfService.getLabel() + ")");

String apiUrl = cfService.getCredentials().getString(CRED_DYNATRACE_APIURL);
if (isBlank(apiUrl)) {
LOG.warning("Credential \"" + CRED_DYNATRACE_APIURL + "\" not found. Skipping dynatrace exporter configuration");
LOG.warning(
"Credential \"" + CRED_DYNATRACE_APIURL + "\" not found. Skipping dynatrace exporter configuration");
return NoopMetricExporter.getInstance();
}
String tokenName = config.getString("otel.javaagent.extension.sap.cf.binding.dynatrace.metrics.token-name");
if (isBlank(tokenName)) {
LOG.warning("Configuration \"otel.javaagent.extension.sap.cf.binding.dynatrace.metrics.token-name\" not found. Skipping dynatrace exporter configuration");
LOG.warning(
"Configuration \"otel.javaagent.extension.sap.cf.binding.dynatrace.metrics.token-name\" not found. Skipping dynatrace exporter configuration");
return NoopMetricExporter.getInstance();
}
String apiToken = cfService.getCredentials().getString(tokenName);
Expand All @@ -102,19 +125,18 @@ public MetricExporter createExporter(ConfigProperties config) {
}

OtlpHttpMetricExporterBuilder builder = OtlpHttpMetricExporter.builder();
builder.setEndpoint(apiUrl + DT_APIURL_METRICS_SUFFIX)
.setCompression(getCompression(config))
.addHeader("Authorization", "Api-Token " + apiToken)
.setRetryPolicy(RetryPolicy.getDefault())
.setAggregationTemporalitySelector(AggregationTemporalitySelector.alwaysCumulative())
.setDefaultAggregationSelector(getDefaultAggregationSelector(config));
builder.setEndpoint(apiUrl + DT_APIURL_METRICS_SUFFIX).setCompression(getCompression(config))
.addHeader("Authorization", "Api-Token " + apiToken).setRetryPolicy(RetryPolicy.getDefault())
.setAggregationTemporalitySelector(getAggregationTemporalitySelector(config))
.setDefaultAggregationSelector(getDefaultAggregationSelector(config));

Duration timeOut = getTimeOut(config);
if (timeOut != null) {
builder.setTimeout(timeOut);
}

LOG.info("Created metrics exporter for service binding " + cfService.getName() + " (" + cfService.getLabel() + ")");
LOG.info(
"Created metrics exporter for service binding " + cfService.getName() + " (" + cfService.getLabel() + ")");
return builder.build();
}

Expand Down