Fix bug4793 in assembly #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tal-sapan
suggested changes
Jun 26, 2019
tal-sapan
reviewed
Jun 27, 2019
tal-sapan
reviewed
Jun 30, 2019
| @@ -37,22 +37,25 @@ var _ = Describe("Commands", func() { | |||
| }) | |||
|
|
|||
| It("Generate Meta", func() { | |||
| os.MkdirAll(getTestPath("result", ".mtahtml5_mta_build_tmp", "testapp"), os.ModePerm) | |||
| dir.CreateDirIfNotExist(getTestPath("result", ".mtahtml5_mta_build_tmp", "testapp")) | |||
There was a problem hiding this comment.
Does this folder have to be created? Shouldn't it exist only in the project's sources?
There was a problem hiding this comment.
no, when creating manifest we check target artifacts in temp folder
There was a problem hiding this comment.
The module's temp folder is under the module's name, not its path, isn't it?
| os.MkdirAll(getTestPath("result", ".mtahtml5_mta_build_tmp", "testapp"), os.ModePerm) | ||
| os.MkdirAll(getTestPath("result", ".mtahtml5_mta_build_tmp", "ui5app2"), os.ModePerm) | ||
| os.MkdirAll(getTestPath("result", ".mtahtml5_mta_build_tmp", "META-INF"), os.ModePerm) | ||
| createMtahtml5TmpFolder() | ||
| file, _ := os.Create(getTestPath("result", ".mtahtml5_mta_build_tmp", "xs-security.json")) |
There was a problem hiding this comment.
You can remove this (it's done inside createMtahtml5TmpFolder)
This comment has been minimized.
This comment has been minimized.
|
The coverage fell because of these missing tests:
|
tal-sapan
reviewed
Jun 30, 2019
tal-sapan
approved these changes
Jun 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug4793 in assembly
Checklist