Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Different inner map type sometimes returned when reading fetcher-opts #487

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

tal-sapan
Copy link
Contributor

@tal-sapan tal-sapan commented Aug 8, 2019

Description

Support both cases (map[string]interface{} and map[interface{}]interface{})
Change all tests to use mta.Unmarshal instead of yaml.Unmarshal when
parsing mta

Before submitting a pull request, please ensure the following:

Checklist

  • Code compiles correctly
  • Relevant tests were added (unit / contract / integration)
  • Relevant logs were added
  • Formatting and linting run locally successfully
  • All tests pass
  • UA review
  • Design is documented
  • Extended the README / documentation, if necessary
  • Open source is approved

…r-opts

Support both cases (map[string]interface{} and map[interface{}]interface{})
Change all tests to use mta.Unmarshal instead of yaml.Unmarshal when
parsing mta
@tal-sapan tal-sapan requested a review from allaVolkov August 8, 2019 12:49
@tal-sapan tal-sapan requested a review from ShimiT as a code owner August 8, 2019 12:49
@tal-sapan
Copy link
Contributor Author

Fix for #488

@tal-sapan tal-sapan changed the title [Fix] Different inner map type sometimes returned when reading fetche-opts [Fix] Different inner map type sometimes returned when reading fetcher-opts Aug 8, 2019
@tal-sapan tal-sapan merged commit 95ca973 into master Aug 8, 2019
@tal-sapan tal-sapan deleted the fix_fetcher_opts branch August 8, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants