Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(docker): adapt expected version pattern #616

Merged
merged 2 commits into from
Dec 1, 2019
Merged

test(docker): adapt expected version pattern #616

merged 2 commits into from
Dec 1, 2019

Conversation

CCFenner
Copy link
Member

@CCFenner CCFenner commented Nov 29, 2019

Description

Test still expected the old output.

sut_1   | Command: mbt --version: stdout: patterns not found: [v1.0.4]

Test expected the minor version to be 0 instead of 1

sut_1   | Command: node --version: stdout: patterns not found: [v12.13.0]

Checklist

  • Code compiles correctly
  • Relevant tests were added (unit / contract / integration)
  • Relevant logs were added
  • Formatting and linting run locally successfully
  • All tests pass
  • UA review
  • Design is documented
  • Extended the README / documentation, if necessary
  • Open source is approved

@CCFenner CCFenner requested a review from ShimiT as a code owner November 29, 2019 11:03
@ShimiT
Copy link
Collaborator

ShimiT commented Dec 1, 2019

LGTM, thanks for your contribution!

@ShimiT ShimiT merged commit 273b247 into SAP:master Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants