Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes in migration section #623

Merged
merged 4 commits into from
Dec 4, 2019
Merged

fixes in migration section #623

merged 4 commits into from
Dec 4, 2019

Conversation

katunin-ng
Copy link
Member

Before submitting a pull request, please ensure the following:

Description

Please explain the changes you made.

Add a link to the design (if applicable).

Checklist

  • Code compiles correctly
  • Relevant tests were added (unit / contract / integration)
  • Relevant logs were added
  • Formatting and linting run locally successfully
  • All tests pass
  • UA review
  • Design is documented
  • Extended the README / documentation, if necessary
  • Open source is approved

Copy link
Contributor

@tal-sapan tal-sapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the text go through a UA review?

docs/docs/migration.md Outdated Show resolved Hide resolved
docs/docs/migration.md Outdated Show resolved Hide resolved
docs/docs/migration.md Outdated Show resolved Hide resolved
docs/docs/migration.md Outdated Show resolved Hide resolved
@ShimiT ShimiT merged commit d9a82d6 into master Dec 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the moremigration branch December 4, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants