Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add troubleshooting for make in Mac #643

Merged
merged 2 commits into from
Dec 26, 2019
Merged

Add troubleshooting for make in Mac #643

merged 2 commits into from
Dec 26, 2019

Conversation

tal-sapan
Copy link
Contributor

Checklist

  • Code compiles correctly
  • Relevant tests were added (unit / contract / integration)
  • Relevant logs were added
  • Formatting and linting run locally successfully
  • All tests pass
  • UA review
  • Design is documented
  • Extended the README / documentation, if necessary
  • Open source is approved

@tal-sapan tal-sapan requested a review from ShimiT as a code owner December 25, 2019 13:27
@tal-sapan tal-sapan requested a review from katunin-ng December 25, 2019 13:29
Paolaufer
Paolaufer reviewed Dec 25, 2019
View reviewed changes
docs/docs/makefile.md Outdated
@@ -1,8 +1,10 @@
## Windows
In order to build an MTA archive from a project's source code in a Windows environment, you should install `GNU Make 4.2.1` on your machine.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To build an MTA archive from a project's source code in a Windows environment, install GNU Make 4.2.1 on your machine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Paolaufer
Paolaufer reviewed Dec 25, 2019
View reviewed changes
docs/docs/makefile.md Outdated

Alternatively, you can use [Chocolatey](https://chocolatey.org/packages/make) to install or upgrade `GNU Make`.


## Mac
If the build fails because `make` cannot run you might have to install the Command-Line Tools. Please refer to the [troubleshooting](troubleshooting.md) topic for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the build fails because make cannot run, you might have to install the Command-Line Tools. See the troubleshooting topic for more details.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Paolaufer
Paolaufer reviewed Dec 25, 2019
View reviewed changes
docs/docs/troubleshooting.md Outdated
@@ -11,29 +11,32 @@ Grant the user "admin" permissions to run the command for the installation proc

```sudo npm install -g mbt --unsafe-perm=true --allow-root```

### Building a Multi-Target Application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building a Multitarget Application

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Paolaufer
Paolaufer reviewed Dec 25, 2019
View reviewed changes
docs/docs/troubleshooting.md Outdated
```

For more details, refer to the npm [documentation](https://docs.npmjs.com/files/npmrc)
For more details, refer to the npm [documentation](https://docs.npmjs.com/files/npmrc).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For more details, see the npm documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Paolaufer
Paolaufer reviewed Dec 25, 2019
View reviewed changes
Copy link
Contributor

@Paolaufer Paolaufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@tal-sapan tal-sapan merged commit c5a25eb into master Dec 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the mac_make_troubleshooting branch December 26, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paolaufer Paolaufer Paolaufer left review comments

@ShimiT ShimiT ShimiT approved these changes

@katunin-ng katunin-ng Awaiting requested review from katunin-ng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tal-sapan @ShimiT @Paolaufer