Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource and requires path in MANIFEST.MF when file is in subfolder #644

Merged
merged 1 commit into from
Dec 25, 2019

Conversation

tal-sapan
Copy link
Contributor

The paths should contain slashes (and not backslashes) regardless of the OS

Checklist

  • Code compiles correctly
  • Relevant tests were added (unit / contract / integration)
  • Relevant logs were added
  • Formatting and linting run locally successfully
  • All tests pass
  • UA review
  • Design is documented
  • Extended the README / documentation, if necessary
  • Open source is approved

The paths should contain slashes (and not backslashes) regardless of the OS
@tal-sapan tal-sapan requested a review from allaVolkov December 25, 2019 15:36
@tal-sapan tal-sapan requested a review from ShimiT as a code owner December 25, 2019 15:36
@tal-sapan tal-sapan merged commit cdd9dc7 into master Dec 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the manifest_resource_path branch December 25, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants