Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix template (issue 654) #657

Merged
merged 1 commit into from
Jan 15, 2020
Merged

fix template (issue 654) #657

merged 1 commit into from
Jan 15, 2020

Conversation

allaVolkov
Copy link
Contributor

fix template (issue 654)

Checklist

  • Code compiles correctly
  • Relevant tests were added (unit / contract / integration)
  • Relevant logs were added
  • Formatting and linting run locally successfully
  • All tests pass
  • UA review
  • Design is documented
  • Extended the README / documentation, if necessary
  • Open source is approved

@allaVolkov
Copy link
Contributor Author

The pull request fixes issue #654.
For specific Windows/make/cmd installation GNU Make wrongly parsed the following command in generated Makefile.mta:
mbt gen mtar -t=${t} --mtar=${mtar} --target_provided=${target_provided} {{- ExtensionsArg "-e"}}
Flag t (target) received the value of target path concatenated with the successor --mtar=...
This problem didn't raise in GitBush of the same consumer and was not reproducible in other environments.
The change fixed it for the problematic environment and didn't cause any regression in others.

@tal-sapan tal-sapan merged commit f316fcf into master Jan 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the issue_654 branch January 15, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants