Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] sitecontent type in mtad.yaml should be com.sap.portal.site-content #725

Merged
merged 1 commit into from
Apr 7, 2020
Merged

[Fix] sitecontent type in mtad.yaml should be com.sap.portal.site-content #725

merged 1 commit into from
Apr 7, 2020

Conversation

tal-sapan
Copy link
Contributor

Remove obsolete and duplicate definitions for sitecontent, hdb and dwf module types.

Description

Add a link to the design (if applicable).

Checklist

  • Code compiles correctly
  • Relevant tests were added (unit / contract / integration)
  • Relevant logs were added
  • Formatting and linting run locally successfully
  • All tests pass
  • UA review
  • Design is documented
  • Extended the README / documentation, if necessary
  • Open source is approved

@tal-sapan
[Fix] sitecontent type in mtad.yaml should be com.sap.portal.site-con…
920e5c2 
…tent

Remove obsolete and duplicate definitions for sitecontent, hdb and dwf.
@tal-sapan tal-sapan requested review from ShimiT and allaVolkov April 7, 2020 13:49
@tal-sapan tal-sapan merged commit 36d44af into master Apr 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix_sitecontent branch April 7, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allaVolkov allaVolkov allaVolkov approved these changes

@ShimiT ShimiT Awaiting requested review from ShimiT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tal-sapan @allaVolkov