Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 [JIRA:HCPSDKFIORIUIKIT-2158] InlineSignatureFormCell (#455) #459

Merged
merged 3 commits into from
Sep 23, 2022
Merged

feat: 🎸 [JIRA:HCPSDKFIORIUIKIT-2158] InlineSignatureFormCell (#455) #459

merged 3 commits into from
Sep 23, 2022

Conversation

janhuachu
Copy link
Contributor

Cherry-picked from main

Also included fix for:
fix: 🐛 [BCP:2170177121] InlineSignature flickering problem (#449)
And use quarternaryFill color instead of quaternaryFill since quaternaryFill is not renamed, yet.

janhuachu and others added 3 commits September 23, 2022 10:43
@janhuachu
feat: 🎸 [JIRA:HCPSDKFIORIUIKIT-2158] InlineSignatureFormCell (SAP#455)
7293229 
no truncation for long key name

✅ Closes: [JIRA:HCPSDKFIORIUIKIT-2158]

(cherry picked from commit b6bf20e)
@janhuachu
fix: 🐛 [BCP:2170177121] InlineSignature flickering problem (SAP#449)
3f6591d 
✅ Closes: BCP:2170177121

(cherry picked from commit ff32b9f)
@janhuachu
chore: 🤖 use quarternaryFill color
4d8ef4a 
In the cherry picked files the quarternaryFill was not yet renamed to
quaternaryFill
@janhuachu janhuachu requested a review from a team as a code owner September 23, 2022 18:03
@janhuachu janhuachu requested review from billzhou0223 and removed request for a team September 23, 2022 18:03
@janhuachu janhuachu merged commit 8b04603 into SAP:integrationSAPFiori7.0 Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billzhou0223 billzhou0223 billzhou0223 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janhuachu @billzhou0223