Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 [HCPSDKFIORIUIKIT-2457] Sidebar #699

Merged
merged 2 commits into from
Jun 10, 2024
Merged

feat: 🎸 [HCPSDKFIORIUIKIT-2457] Sidebar #699

merged 2 commits into from
Jun 10, 2024

Conversation

JunSong-SH
Copy link
Contributor

This PR handle the change for the Sidebar control.

The main change includes:

  1. Rename the original SideBar and SideBarListItem controls generated via Sourcery for old data model to _SideBar and _SideBarListItem. Also, the related extension and demo were changed to refer the new control name.
  2. Generate the new Sidebar and SideBarListItem controls generated for new data model. To add _FilledIconComponent, _AccessoryIconComponent as BaseComponentProtocols. Add _SideBarComponent and _SideBarListItemComponent as CompositeComponentProtocols.
  3. Handle the detail logic for SideBar in SideBarStyle.fiori.swift and SideBarListItemStyle.fiori.swift.
  4. Add file EditableSideBarExample.swift and landmarkData.json for the new SideBar control demo.

@JunSong-SH JunSong-SH requested a review from a team as a code owner June 4, 2024 07:20
@JunSong-SH JunSong-SH requested review from billzhou0223 and removed request for a team June 4, 2024 07:20
@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Jun 4, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JunSong-SH JunSong-SH force-pushed the main-sidebar branch 8 times, most recently from b87b2ed to 2dc3dd7 Compare June 4, 2024 16:22
dyongxu
dyongxu requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@dyongxu dyongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update test data

@JunSong-SH JunSong-SH requested a review from dyongxu June 7, 2024 08:54
@JunSong-SH
Copy link
Contributor Author

update test data

Done! Renew the data for Demo. Thanks!

hound[bot]
hound bot reviewed Jun 7, 2024
View reviewed changes
Sources/FioriSwiftUICore/_FioriStyles/AccessoryIconStyle.fiori.swift
import SwiftUI

//
/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orphaned Doc Comment Violation: A doc comment should be attached to a declaration. (orphaned_doc_comment)

hound[bot]
hound bot reviewed Jun 7, 2024
View reviewed changes
Sources/FioriSwiftUICore/_FioriStyles/AccessoryIconStyle.fiori.swift
import SwiftUI

//
/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orphaned Doc Comment Violation: A doc comment should be attached to a declaration. (orphaned_doc_comment)

Sources/FioriSwiftUICore/_FioriStyles/FilledIconStyle.fiori.swift
import SwiftUI

//
/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orphaned Doc Comment Violation: A doc comment should be attached to a declaration. (orphaned_doc_comment)

hound[bot]
hound bot reviewed Jun 7, 2024
View reviewed changes
Sources/FioriSwiftUICore/_FioriStyles/AccessoryIconStyle.fiori.swift
import SwiftUI

//
/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orphaned Doc Comment Violation: A doc comment should be attached to a declaration. (orphaned_doc_comment)

Sources/FioriSwiftUICore/_FioriStyles/FilledIconStyle.fiori.swift
import SwiftUI

//
/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orphaned Doc Comment Violation: A doc comment should be attached to a declaration. (orphaned_doc_comment)

Sources/FioriSwiftUICore/_FioriStyles/SideBarListItemStyle.fiori.swift
import SwiftUI

//
/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orphaned Doc Comment Violation: A doc comment should be attached to a declaration. (orphaned_doc_comment)

hound[bot]
hound bot reviewed Jun 7, 2024
View reviewed changes
Sources/FioriSwiftUICore/_FioriStyles/AccessoryIconStyle.fiori.swift
import SwiftUI

//
/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orphaned Doc Comment Violation: A doc comment should be attached to a declaration. (orphaned_doc_comment)

Sources/FioriSwiftUICore/_FioriStyles/FilledIconStyle.fiori.swift
import SwiftUI

//
/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orphaned Doc Comment Violation: A doc comment should be attached to a declaration. (orphaned_doc_comment)

Sources/FioriSwiftUICore/_FioriStyles/SideBarListItemStyle.fiori.swift
import SwiftUI

//
/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orphaned Doc Comment Violation: A doc comment should be attached to a declaration. (orphaned_doc_comment)

@billzhou0223 billzhou0223 merged commit 7ba8bdb into SAP:main Jun 10, 2024
11 checks passed
@JunSong-SH JunSong-SH deleted the main-sidebar branch June 11, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound hound[bot] hound[bot] left review comments

@dyongxu dyongxu dyongxu approved these changes

@billzhou0223 billzhou0223 billzhou0223 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JunSong-SH @billzhou0223 @dyongxu