fix: 🐛 [JIRA: HCPSDKFIORIUIKIT-2478] banner message style #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xiaoyu0722
commented
Jul 22, 2024
xiaoyu0722
commented
- Add icon support for banner message.
- Add new cases for long title and different styles.
Apps/Examples/Examples/FioriSwiftUICore/BannerMessage/BannerMessageModifierExample.swift
Outdated
Show resolved
Hide resolved
|
@xiaoyu0722 HCPSDKFIORIUIKIT-1940 is for ProfileHeader. The changes do not seem to have anything to do with ProfileHeader. |
xiaoyu0722
force-pushed
the
fix-banner-message-style
branch
from
604a75f
to
d03b595
Compare
xiaoyu0722
changed the title
Sorry, my mistake, I have updated the commit message. Thanks. 👍 |
billzhou0223
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.