-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 [JIRA:HCPSDKFIORIUIKIT-2702]Illustrated Message Enhancement #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[JIRA:HCPSDKFIORIUIKIT-2702]Illustrated Message Enhancement. Cherrypick from main.
billzhou0223
approved these changes
Aug 21, 2024
billzhou0223
added a commit
that referenced
this pull request
Sep 13, 2024
* feat: 🎸 [JIRA:HCPSDKFIORIUIKIT-2702]Illustrated Message (#782) [JIRA:HCPSDKFIORIUIKIT-2702]Illustrated Message Enhancement. Cherrypick from main. Co-authored-by: I824136 <xiaoqing.he@sap.com> * chore: 🤖 fix layout issue in Icons and IconBuilder * fix: 🐛 [HCPSDKFIORIUIKIT-2720] Style updates in ObjectItem * chore(release): 4.1.4 * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update (#795) * chore: 🤖 fix layout issue in Icons and IconBuilder * fix: 🐛 [HCPSDKFIORIUIKIT-2720] Style updates in ObjectItem * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update * fix: 🐛 [FIORIDESIGN-13047] Joule Menu Selection Icon Update * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update (#795) (#796) * chore: 🤖 fix layout issue in Icons and IconBuilder * fix: 🐛 [HCPSDKFIORIUIKIT-2720] Style updates in ObjectItem * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update * fix: 🐛 [FIORIDESIGN-13047] Joule Menu Selection Icon Update * fix: 🐛 [FIORIDESIGN-13047] Joule Menu Selection Icon Update (#798) * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update (#795) * chore: 🤖 fix layout issue in Icons and IconBuilder * fix: 🐛 [HCPSDKFIORIUIKIT-2720] Style updates in ObjectItem * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update * fix: 🐛 [FIORIDESIGN-13047] Joule Menu Selection Icon Update * fix: 🐛 [JIRA:IOSSDKBUG-324]Usage of SwiftUI KeyValueFormView (#790) * fix: 🐛 [JIRA:IOSSDKBUG-324]Usage of SwiftUI KeyValueFormView ✅ Closes: IOSSDKBUG-324 * fix: 🐛 [JIRA:IOSSDKBUG-324]Usage of SwiftUI KeyValueFormView --------- Co-authored-by: I824136 <xiaoqing.he@sap.com> * docs: ✏️ changelog for 4.1.5 --------- Co-authored-by: xiaoqinggrace <52239714+xiaoqinggrace@users.noreply.github.com> Co-authored-by: I824136 <xiaoqing.he@sap.com> Co-authored-by: Marco Eidinger <marco.eidinger@sap.com>
billzhou0223
added a commit
that referenced
this pull request
Jan 23, 2025
* feat: 🎸 [JIRA:HCPSDKFIORIUIKIT-2702]Illustrated Message (#782) [JIRA:HCPSDKFIORIUIKIT-2702]Illustrated Message Enhancement. Cherrypick from main. Co-authored-by: I824136 <xiaoqing.he@sap.com> * chore: 🤖 fix layout issue in Icons and IconBuilder * fix: 🐛 [HCPSDKFIORIUIKIT-2720] Style updates in ObjectItem * chore(release): 4.1.4 * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update (#795) * chore: 🤖 fix layout issue in Icons and IconBuilder * fix: 🐛 [HCPSDKFIORIUIKIT-2720] Style updates in ObjectItem * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update * fix: 🐛 [FIORIDESIGN-13047] Joule Menu Selection Icon Update * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update (#795) (#796) * chore: 🤖 fix layout issue in Icons and IconBuilder * fix: 🐛 [HCPSDKFIORIUIKIT-2720] Style updates in ObjectItem * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update * fix: 🐛 [FIORIDESIGN-13047] Joule Menu Selection Icon Update * fix: 🐛 [FIORIDESIGN-13047] Joule Menu Selection Icon Update (#798) * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update (#795) * chore: 🤖 fix layout issue in Icons and IconBuilder * fix: 🐛 [HCPSDKFIORIUIKIT-2720] Style updates in ObjectItem * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update * fix: 🐛 [FIORIDESIGN-13047] Joule Menu Selection Icon Update * fix: 🐛 [JIRA:IOSSDKBUG-324]Usage of SwiftUI KeyValueFormView (#790) * fix: 🐛 [JIRA:IOSSDKBUG-324]Usage of SwiftUI KeyValueFormView ✅ Closes: IOSSDKBUG-324 * fix: 🐛 [JIRA:IOSSDKBUG-324]Usage of SwiftUI KeyValueFormView --------- Co-authored-by: I824136 <xiaoqing.he@sap.com> * docs: ✏️ changelog for 4.1.5 * feat: 🎸 MenuSelectionItem disabled state * chore: 🤖 add a preview for disabled state in MenuSelectionItem * chore: 🤖 MenuSelection action always enabled --------- Co-authored-by: xiaoqinggrace <52239714+xiaoqinggrace@users.noreply.github.com> Co-authored-by: I824136 <xiaoqing.he@sap.com> Co-authored-by: Marco Eidinger <marco.eidinger@sap.com>
billzhou0223
added a commit
that referenced
this pull request
Feb 25, 2025
* feat: 🎸 [JIRA:HCPSDKFIORIUIKIT-2702]Illustrated Message (#782) [JIRA:HCPSDKFIORIUIKIT-2702]Illustrated Message Enhancement. Cherrypick from main. Co-authored-by: I824136 <xiaoqing.he@sap.com> * chore: 🤖 fix layout issue in Icons and IconBuilder * fix: 🐛 [HCPSDKFIORIUIKIT-2720] Style updates in ObjectItem * chore(release): 4.1.4 * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update (#795) * chore: 🤖 fix layout issue in Icons and IconBuilder * fix: 🐛 [HCPSDKFIORIUIKIT-2720] Style updates in ObjectItem * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update * fix: 🐛 [FIORIDESIGN-13047] Joule Menu Selection Icon Update * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update (#795) (#796) * chore: 🤖 fix layout issue in Icons and IconBuilder * fix: 🐛 [HCPSDKFIORIUIKIT-2720] Style updates in ObjectItem * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update * fix: 🐛 [FIORIDESIGN-13047] Joule Menu Selection Icon Update * fix: 🐛 [FIORIDESIGN-13047] Joule Menu Selection Icon Update (#798) * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update (#795) * chore: 🤖 fix layout issue in Icons and IconBuilder * fix: 🐛 [HCPSDKFIORIUIKIT-2720] Style updates in ObjectItem * fix: 🐛 [IOSSDKBUG-346] JouleWelcomeScreen title style update * fix: 🐛 [FIORIDESIGN-13047] Joule Menu Selection Icon Update * fix: 🐛 [JIRA:IOSSDKBUG-324]Usage of SwiftUI KeyValueFormView (#790) * fix: 🐛 [JIRA:IOSSDKBUG-324]Usage of SwiftUI KeyValueFormView ✅ Closes: IOSSDKBUG-324 * fix: 🐛 [JIRA:IOSSDKBUG-324]Usage of SwiftUI KeyValueFormView --------- Co-authored-by: I824136 <xiaoqing.he@sap.com> * docs: ✏️ changelog for 4.1.5 * feat: 🎸 MenuSelectionItem disabled state * chore: 🤖 add a preview for disabled state in MenuSelectionItem * chore: 🤖 MenuSelection action always enabled * fix: 🐛 shadow effect for MenuSelectionItem (IOSSDKBUG-233) --------- Co-authored-by: xiaoqinggrace <52239714+xiaoqinggrace@users.noreply.github.com> Co-authored-by: I824136 <xiaoqing.he@sap.com> Co-authored-by: Marco Eidinger <marco.eidinger@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick from main.