feat: 🎸 HCPSDKFIORIUIKIT-2718 Mandatory Field for DateTimePicker #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Mandatory Field Styling for DateTimePicker. Add controlState for disable/readonly state. Add informationView for the error/hint message.
xiaoqinggrace
requested review from
billzhou0223
and removed request for
a team
angiexyang
reviewed
Oct 2, 2024
| @@ -3,10 +3,13 @@ import Foundation | |||
| import SwiftUI | |||
|
|
|||
| struct DateTimePickerExample: View { | |||
| @State var s1: Date = .init() | |||
| @State var s1: Date = .init(timeIntervalSince1970: 0.0) | |||
There was a problem hiding this comment.
Maybe we can make selectedDate an optional value for developers, and set Date(timeIntervalSince1970: 0.0) internally if selectedDate is empty. In UIKit, developers can set cell.value = nil to show "No Date Selected"
There was a problem hiding this comment.
If we implement this, we need to change the model and ensure the application passes the binding value.
angiexyang
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Mandatory Field Styling for DateTimePicker. Add controlState for disable/readonly state. Add informationView for the error/hint message.