feat: 🎸 [JIRA:HCPSDKFIORIUIKIT-2717] Feedback Patterns #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hengyi-zhang
requested review from
billzhou0223
and removed request for
a team
hengyi-zhang
changed the title
hengyi-zhang
changed the title
dyongxu
approved these changes
Oct 22, 2024
billzhou0223
requested changes
Oct 22, 2024
Sources/FioriSwiftUICore/_FioriStyles/BannerMultiMessageSheet.fiori.swift
Outdated
Show resolved
Hide resolved
Sources/FioriSwiftUICore/_FioriStyles/BannerMultiMessageSheet.fiori.swift
Outdated
Show resolved
Hide resolved
Sources/FioriSwiftUICore/_FioriStyles/BannerMultiMessageSheet.fiori.swift
Outdated
Show resolved
Hide resolved
billzhou0223
requested changes
Oct 24, 2024
Sources/FioriSwiftUICore/_FioriStyles/BannerMultiMessageSheet.fiori.swift
Outdated
Show resolved
Hide resolved
Sources/FioriSwiftUICore/_FioriStyles/BannerMultiMessageSheet.fiori.swift
Outdated
Show resolved
Hide resolved
…protocols Modify sourcery script to adapt the viewbuilder with parameters in closure
hengyi-zhang
force-pushed
the
feat/HCPSDKFIORIUIKIT-2717
branch
from
b2ad479 to
e954845
Compare
billzhou0223
requested changes
Oct 31, 2024
Sources/FioriSwiftUICore/_ComponentProtocols/CompositeComponentProtocols.swift
Outdated
Show resolved
Hide resolved
dyongxu
approved these changes
Nov 5, 2024
Merge main branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.