Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 [HCPSDKFIORIUIKIT-2766] sort & filter enhancement stepper #851

Merged
merged 2 commits into from
Oct 31, 2024
Merged

feat: 🎸 [HCPSDKFIORIUIKIT-2766] sort & filter enhancement stepper #851

merged 2 commits into from
Oct 31, 2024

Conversation

restaurantt
Copy link
Contributor

@restaurantt restaurantt requested a review from a team as a code owner October 31, 2024 06:38
@restaurantt restaurantt requested review from billzhou0223 and removed request for a team October 31, 2024 06:38
dyongxu
dyongxu approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@dyongxu dyongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed yesterday, SortFilterFeedbackBar was adjusted for visionOS colors. It is already checked in Hengyi.
You can merge this for now. Then have another PR to adjust for visionOS similar to what Hengyi did.

@dyongxu dyongxu merged commit ee4e9cb into SAP:main Oct 31, 2024
12 checks passed
@restaurantt restaurantt deleted the main-filterFeedback-enhancement-stepper branch November 22, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyongxu dyongxu dyongxu approved these changes

@billzhou0223 billzhou0223 billzhou0223 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@restaurantt @billzhou0223 @dyongxu