feat: 🎸 [JIRA:IOSSDKBUG-434] filterFeedBack list mutil selections shown in section #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restaurantt
requested review from
billzhou0223
and removed request for
a team
filterFeedBack list mutil selections shown in section
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| public init(id: String = UUID().uuidString, name: String, value: [Int], valueOptions: [String], allowsMultipleSelection: Bool, allowsEmptySelection: Bool, barItemDisplayMode: BarItemDisplayMode = .name, isSearchBarHidden: Bool = false, icon: String? = nil, itemLayout: OptionListPickerItemLayoutType = .fixed, displayMode: DisplayMode = .automatic) { | ||
| /// Enum for list show entries section | ||
| /// The default value is `.default`. | ||
| public enum ListEntriesSectionMode { |
There was a problem hiding this comment.
Nesting Violation: Types should be nested at most 1 level deep (nesting)
| #else | ||
| .foregroundStyle(Color.preferredColor(.primaryLabel)) | ||
| #endif | ||
| if !disableListEntriesSection, _value.count > 0 { |
There was a problem hiding this comment.
Empty Count Violation: Prefer checking isEmpty over comparing count to zero. (empty_count)
| public init(id: String = UUID().uuidString, name: String, value: [Int], valueOptions: [String], allowsMultipleSelection: Bool, allowsEmptySelection: Bool, barItemDisplayMode: BarItemDisplayMode = .name, isSearchBarHidden: Bool = false, icon: String? = nil, itemLayout: OptionListPickerItemLayoutType = .fixed, displayMode: DisplayMode = .automatic) { | ||
| /// Enum for list show entries section | ||
| /// The default value is `.default`. | ||
| public enum ListEntriesSectionMode { |
There was a problem hiding this comment.
Nesting Violation: Types should be nested at most 1 level deep (nesting)
| #else | ||
| .foregroundStyle(Color.preferredColor(.primaryLabel)) | ||
| #endif | ||
| if !disableListEntriesSection, _value.count > 0 { |
There was a problem hiding this comment.
Empty Count Violation: Prefer checking isEmpty over comparing count to zero. (empty_count)
dyongxu
approved these changes
Nov 6, 2024
billzhou0223
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'ListEntriesSectionMode' to control whether entries section shown or not.
when listEntriesSectionMode is 'default', depends on 'allowsMultipleSelection', when allowsMultipleSelection is true, selections should be shown in an individual section.