Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 [IOSSDKBUG-455] FilterFeedbackBar maxWidth customization #878

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

restaurantt
Copy link
Contributor

@restaurantt restaurantt commented Nov 12, 2024

Add 'maxWidth' in 'filterFeedbackBarStyle'. If width is not enough, text will be truncated.

@restaurantt restaurantt requested a review from a team as a code owner November 12, 2024 09:12
@restaurantt restaurantt requested review from billzhou0223 and removed request for a team November 12, 2024 09:12
Copy link
Contributor

@dyongxu dyongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test case in TestApp, to show this behavior

@restaurantt
Copy link
Contributor Author

turn on the Custom Style switch at the bottom, it will active the custom style.
Simulator Screenshot - iPhone 16 Pro Max - 2024-11-13 at 08 58 26

@restaurantt restaurantt requested a review from dyongxu November 13, 2024 01:21
@dyongxu dyongxu merged commit 207a8c2 into SAP:main Nov 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants