-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static pages for Business Accelerator Hub #525
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only Minor comments, looks great!
Also:
- Will the
✅ API Client generation tested but no download available
note be removed? - Will the latest version of the generator be automatically updated?
Co-authored-by: Charles Dubois <103174266+CharlesDuboisSAP@users.noreply.github.com>
Yes I expect everything on the right sidebar to be removed. Similar as is for ABAP.
No, unfortunately not. We could investigate and pitch a JS script that updates the content on site-load by querying Maven Central. But chances for having that approved are probably low. GDPR does not allow for random third-party requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Co-authored-by: Charles Dubois <103174266+CharlesDuboisSAP@users.noreply.github.com>
Context
SAP/cloud-sdk-java-backlog#457
We want an updated static page for generating type-safe clients with SAP Cloud SDK on Business Accelerator Hub.
In Reivew:
Other: