chore: [DevOps] Update Apache httpclient5 to 5.4.2 #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlesDuboisSAP
added
please merge
newtork
reviewed
Feb 13, 2025
| @@ -23,27 +23,6 @@ final class PreparedEntityBluePrint | |||
| @Nonnull | |||
| private final JDefinedClass entityClass; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
(Minor)
Drive-by / Unrelated change
There was a problem hiding this comment.
I know, this is part of the "Drive-by Java 23 compatibility"
newtork
reviewed
Feb 13, 2025
| <annotationProcessorPaths> | ||
| <annotationProcessorPath> | ||
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> |
There was a problem hiding this comment.
(Minor)
Drive-by / Unrelated change
There was a problem hiding this comment.
I know, this is part of the "Drive-by Java 23 compatibility"
newtork
reviewed
Feb 13, 2025
release_notes.md
Outdated
| @@ -8,7 +8,11 @@ | |||
|
|
|||
| ### 🔧 Compatibility Notes | |||
|
|
|||
| - | |||
| - The TLS `Upgrade` header changes thanks to [Apache httpclient5 5.4.2](https://github.com/apache/httpcomponents-client/commit/5ab09ea39fed1c39ea35905532ba1567c785330a) | |||
There was a problem hiding this comment.
(Minor)
Please rephrase ;)
There was a problem hiding this comment.
Is it better now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
SAP/cloud-sdk-java-backlog#448.
Apache httpclient5 has a behaviour change with the TLS
Upgradeheader in 5.4.2The new behaviour is hard coded in Apache:
Upgradeheader if Connection header already presentFeature scope:
Upgradeheader, which is now default (new test case)Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updated