Skip to content

Commit

Permalink
chore: switch workflows to use node 20 and 22 by default (#5046)
Browse files Browse the repository at this point in the history
* support node 20

* Update .github/workflows/build.yml

* use 22

* ignore engines everywhere

* Update .github/workflows/blackduck.yml
  • Loading branch information
marikaner authored Oct 11, 2024
1 parent bd06467 commit 97d1b69
Show file tree
Hide file tree
Showing 9 changed files with 27 additions and 26 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/auto-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
- run: git fetch --depth=1
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'yarn'
- name: Install Dependencies
run: yarn install --frozen-lockfile
run: yarn install --frozen-lockfile --ignore-engines
- name: Run Lint
run: yarn lint:fix
- name: Commit Changes if needed
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/blackduck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ jobs:
- run: git fetch --depth=1
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'yarn'
- run: yarn install --frozen-lockfile
- run: yarn install --frozen-lockfile --ignore-engines
- run: sudo apt-get install jq
- run: echo "project_version=$(cat package.json | jq '.version' | tr -d '"')" >> $GITHUB_ENV
- name: Blackduck Scan
Expand Down
21 changes: 11 additions & 10 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [18]
node-version: [18, 20, 22]
steps:
- uses: actions/checkout@v4
- run: git fetch --depth=1
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'yarn'
- run: yarn install --ignore-engines --frozen-lockfile
- run: yarn install --frozen-lockfile --ignore-engines
- run: yarn test:unit
env:
SANDBOX_TOKEN: ${{ secrets.API_HUB_SANDBOX_TOKEN }}
Expand Down Expand Up @@ -62,11 +62,11 @@ jobs:
- run: git fetch --depth=1
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'yarn'
- name: REUSE Compliance Check
uses: fsfe/reuse-action@v4
- run: yarn install --frozen-lockfile
- run: yarn install --frozen-lockfile --ignore-engines
- run: yarn lint
name: Static Code Check
- run: yarn check:test-service
Expand Down Expand Up @@ -104,10 +104,11 @@ jobs:
- run: git fetch --depth=1
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'yarn'
- run: yarn install --frozen-lockfile
- run: yarn install --frozen-lockfile --ignore-engines
- run: yarn test:e2e

dependabot:
runs-on: ubuntu-latest
if: ${{ github.actor == 'dependabot[bot]' && github.event_name == 'pull_request' }}
Expand Down Expand Up @@ -167,10 +168,10 @@ jobs:
- run: git fetch --depth=1
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'yarn'
registry-url: 'https://registry.npmjs.org'
- run: yarn install --frozen-lockfile
- run: yarn install --frozen-lockfile --ignore-engines
- name: Canary Release
run: |
date=`date +%Y%m%d%H%M%S`
Expand All @@ -191,9 +192,9 @@ jobs:
- run: git fetch --depth=1
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'yarn'
- run: yarn install --frozen-lockfile
- run: yarn install --frozen-lockfile --ignore-engines
- uses: ./.github/actions/get-changelog
name: Get Changelog
id: get-changelog
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/bump.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'yarn'

- run: yarn install --frozen-lockfile
- run: yarn install --frozen-lockfile --ignore-engines

- name: bump version
id: bump
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/downloads.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:
- run: git fetch --depth=1
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'yarn'
- run: yarn install --frozen-lockfile
- run: yarn install --frozen-lockfile --ignore-engines
- run: yarn ts-node scripts/npm-stats.ts
name: Download Stats
4 changes: 2 additions & 2 deletions .github/workflows/memory-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'yarn'
- run: yarn install --frozen-lockfile
- run: yarn install --frozen-lockfile --ignore-engines
name: install root
- run: yarn workspace @sap-cloud-sdk/e2e-tests pretest:e2e
name: start e2e tests server
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ jobs:
ref: 'main'
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
registry-url: 'https://registry.npmjs.org'
- run: yarn install --frozen-lockfile
- run: yarn install --frozen-lockfile --ignore-engines
- name: Legacy Release
if: startsWith(github.ref, 'refs/tags/v1') || startsWith(github.ref, 'refs/tags/v2')
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tests-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ jobs:
- run: git fetch --depth=1
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'yarn'
- run: yarn install --frozen-lockfile
- run: yarn install --frozen-lockfile --ignore-engines
- run: yarn test:unit
- run: yarn test:integration
if: always()
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/typedoc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- run: git fetch --depth=1
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'yarn'
- run: yarn install --frozen-lockfile
- run: yarn install --frozen-lockfile --ignore-engines
- run: yarn doc

0 comments on commit 97d1b69

Please sign in to comment.