use native *_wa variables

[lucasborin]

Strangely, Code Pal was built not using the "*_wa" variables (structure_wa, statement_wa, and token_wa). Most of the native features available in the Code Inspector use these variables. Therefore, let's change it.

[pokrakam]

Why?
I find a simple name perfectly readable:

  LOOP AT statements INTO data(statement).
    IF statement-token[ 1 ].
    ...

vs.

  LOOP AT statements INTO data(statement_wa).
    IF statement_wa-token[ 1 ].
    ...

Why do we need to pollute it with _wa, what do we gain'?
In my opinion this is just another old naming habit that we are trying to get away from.

[lucasborin]

I am with you, we should avoid this _wa always. It goes against the Clean ABAP style guide.

However, it comes from the inherited Code Inspector framework (CL_CI_TEST_SCAN) unfortunately.

And, internally, the framework uses these _wa variables. For instance, to get the main keyword for the statement under scan:

So, it is required to use these variables to enable the reuse here.

Therefore:

😞

[lucasborin]

I'll focus on the main Code Pal class (Y_CHECK_BASE) as it handles the structure and statementunderscan. Thetokens` as under the Checks, and it is up to the Check to decide if it is required.