Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove static dependency to developer version of abapGit #524

Closed
ConjuringCoffee opened this issue Nov 10, 2021 · 1 comment · Fixed by #530 or #529
Closed

Remove static dependency to developer version of abapGit #524

ConjuringCoffee opened this issue Nov 10, 2021 · 1 comment · Fixed by #530 or #529
Assignees
@lucasborin

Comments

@ConjuringCoffee
Copy link
Contributor

ConjuringCoffee commented Nov 10, 2021 •
edited
Loading

Class Y_CODE_PAL_SERVICE has a dependency to the developer version of abapGit. In method EXECUTE_GET_VERSIONS it uses ZIF_ABAPGIT_VERSION=>GC_ABAP_VERSION. This causes a syntax error if only abapGit standalone version (or no abapGit) is installed.

Is it possible to remove this static dependency? Maybe use the parameter dynamically and handle it with an exception if abapGit is not installed?
@ConjuringCoffee ConjuringCoffee changed the title Remove dependency to developer version of abapGit Remove static dependency to developer version of abapGit Nov 10, 2021
@lucasborin
Copy link
Member

We can drop it. I created it in the past to automate the code pal upgrade in some internal systems, but it is no longer in use.

@lucasborin lucasborin self-assigned this Nov 10, 2021
lucasborin pushed a commit that referenced this issue Nov 10, 2021
solves #524
0c409c8
@ConjuringCoffee ConjuringCoffee mentioned this issue Nov 10, 2021
Closed
@lucasborin lucasborin linked a pull request Nov 10, 2021 that will close this issue
Removing Service #530
Merged
lucasborin added a commit that referenced this issue Nov 10, 2021
@lucasborin
Removing Service (#530)
8438f07 
* solves #524

* changelog

* removing it from the documentation

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>
@lucasborin lucasborin linked a pull request Nov 10, 2021 that will close this issue
1.16.3 #529
Merged
@lucasborin lucasborin removed a link to a pull request Nov 11, 2021
1.16.3 #529
Merged
@lucasborin lucasborin linked a pull request Nov 11, 2021 that will close this issue
1.16.3 #529
Merged
lucasborin added a commit that referenced this issue Nov 11, 2021
@lucasborin
1.16.3 (#529)
4f6936f 
* updating changelog

* new version

* Removing Service (#530)

* solves #524

* changelog

* removing it from the documentation

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* Refactoring Function Check (#531)

* fixes #526

* changelog

* Start statement at tab position

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* SUT Dependency (#533)

* forcing cspell to track sut dependencies

* changelog

* fixing #527

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>
ghost pushed a commit that referenced this issue Feb 18, 2022
@lucasborin @abaplint
1.16.3 - rollback (#551)
04414f2 
* updating changelog

* new version

* Removing Service (#530)

* solves #524

* changelog

* removing it from the documentation

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* Refactoring Function Check (#531)

* fixes #526

* changelog

* Start statement at tab position

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* SUT Dependency (#533)

* forcing cspell to track sut dependencies

* changelog

* fixing #527

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* changelog

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update y_check_function.clas.abap

* Update y_check_function.clas.abap

* Update src/checks/y_check_function.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_function.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update y_check_function.clas.abap

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.com>
Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasborin lucasborin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing Service SAP/code-pal-for-abap
1.16.3 SAP/code-pal-for-abap
2 participants
@lucasborin @ConjuringCoffee