Coverage Thresholds #249
Merged
Coverage Thresholds #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
We have to inform via changelog or how-to-upgrade that the user has to reactivate the check (SCI+Variant) to consider the new threshold. |
estevao-schultz-neto-SAP
approved these changes
Nov 20, 2020
|
if you want to notify users, by invalidating the configuration, I have previously had luck by increase the version it looks like there is a central version number for all checks, it should of cause only affect the check with updated configuration |
|
Nice! Thanks for sharing it @larshp. I will increase the check version. |
lucasborin
added a commit
that referenced
this pull request
Nov 23, 2020
* regression feature (#245) * Update changelog.txt * fixing typo (#247) * Update changelog.txt * Update changelog.txt * Split 'Check LOOP' check (#246) * solves #223 * Update check_documentation.md * Create check-in-loop.md * Update check-in-loop.md * Update check-in-loop.md * Update check-statement-position.md * Update check-in-loop.md Co-authored-by: estevao-schultz-neto-SAP <63100656+estevao-schultz-neto-SAP@users.noreply.github.com> * Update changelog.txt * Coverage Thresholds (#249) * solves #243 * versioning check * fixing version * Update changelog.txt * Update check_documentation.md * Create deprecated-classes.md * Update check_documentation.md * Delete deprecated-classes.md * Deprecated Classes (#248) * new check #236 * Update check_documentation.md * Create deprecated-classes.md * Update check_documentation.md * Update y_demo_failures.clas.abap * Update changelog.txt * fixing dump (c_info > c_note) * new version * solves #252 * solves #198 Co-authored-by: estevao-schultz-neto-SAP <63100656+estevao-schultz-neto-SAP@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.