Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance of DB Access in UT Check #320

Merged
28 commits merged into from
Feb 10, 2021
Merged

Performance of DB Access in UT Check #320

28 commits merged into from
Feb 10, 2021

Conversation

lucasborin
Copy link
Member

No description provided.

lucasborin and others added 19 commits January 18, 2021 17:41
@lucasborin
Update README.md
59e3014
@lucasborin
disabling rfc
157a09d
@lucasborin
Merge pull request #305 from SAP/rfc-enabled
6688830 
disabling rfc
@lucasborin
Update changelog.txt
0e23136
@lucasborin
Update changelog.txt
1fb7884
@lucasborin
Merge branch 'master' into 1.12.0
62f4b01
@lucasborin
Merge branch 'master' into 1.12.0
2ede21a
@lucasborin
1.12.0
6b10dd6
Profile Tool - UX Refinement (#313)
0ba96c6 
Minor UX Changes
@lucasborin
Update changelog.txt
ea6ea0b
@lucasborin
Update changelog.txt
377bdea
@lucasborin
Performance (#317)
c2c328d 
* buffer size

* fixing dump when object is not supported by sci

* solving dump when ref scan is not set

* Update y_ref_scan_manager.clas.abap
@lucasborin
Update changelog.txt
52c3889
@lucasborin
removing shared memory (#319)
f471492
@lucasborin
Update changelog.txt
bcc6f7d
@lucasborin
Performance Improvements (#318)
edc36a0 
* moving application component valid. to ref_scan

* wip

* changing validation sequence

* fixing minor bug

* fixing bug

* refactoring former buffer

* syntax error

* fixing ut

* fixing unit test base

* abaplint hint
@lucasborin
Update changelog.txt
656fd0e
@lucasborin
Merge branch 'master' into 1.12.0
d17eedf
@lucasborin
wip
ce1a43a
@lucasborin lucasborin changed the title Performance in DB Access in UT Check Performance of DB Access in UT Check Feb 5, 2021
@ghost ghost assigned lucasborin and ghost Feb 8, 2021
@ghost ghost self-requested a review February 8, 2021 07:48
@ghost ghost linked an issue Feb 8, 2021 that may be closed by this pull request
Improve Performance of the check: "DB in UT" #321
Closed
ghost
ghost previously approved these changes Feb 8, 2021
View reviewed changes
@lucasborin lucasborin marked this pull request as ready for review February 8, 2021 12:19
@lucasborin
Copy link
Member Author

Let's run a performance test to validate it.

@larshp
Copy link
Contributor

larshp commented Feb 8, 2021

Is ALTER a ABAP statement? Or perhaps I'm missing something, or its a new feature?

@lucasborin
Code review (#322)
158c7ae 
* removing unused exception

* solving empty catch

* moving buffer cleanup

* pretty printer
@estevao-schultz-neto-SAP
Copy link
Contributor

Is ALTER a ABAP statement? Or perhaps I'm missing something, or its a new feature?

ALTER TABLE.

lucasborin
lucasborin commented Feb 8, 2021
View reviewed changes
src/checks/y_check_db_access_in_ut.clas.abap Show resolved Hide resolved
src/checks/y_check_db_access_in_ut.clas.abap Show resolved Hide resolved
src/checks/y_check_db_access_in_ut.clas.abap Outdated Show resolved Hide resolved
src/checks/y_check_db_access_in_ut.clas.abap Outdated Show resolved Hide resolved
src/checks/y_check_db_access_in_ut.clas.abap Outdated Show resolved Hide resolved
src/checks/y_check_db_access_in_ut.clas.abap Outdated Show resolved Hide resolved
src/checks/y_check_db_access_in_ut.clas.abap Outdated Show resolved Hide resolved
src/checks/y_check_db_access_in_ut.clas.testclasses.abap
@@ -440,7 +440,6 @@ CLASS ltc_exec_sql IMPLEMENTATION.
ENDCLASS.



CLASS ltc_attribution DEFINITION INHERITING FROM ltc_risk_harmless FOR TESTING RISK LEVEL HARMLESS DURATION SHORT.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to add a new unit test having two local classes

Base automatically changed from 1.12.0 to master February 8, 2021 16:49
@lucasborin lucasborin dismissed ghost ’s stale review February 8, 2021 16:49

The base branch was changed.

@lucasborin lucasborin changed the base branch from master to 1.13.0 February 8, 2021 18:19
@lucasborin
Copy link
Member Author

Is ALTER a ABAP statement? Or perhaps I'm missing something, or its a new feature?

You can use an ALTER within the EXEC SQL :
https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapexec.htm

@ghost ghost requested review from a team and removed request for a user February 9, 2021 12:59
@ghost ghost merged commit c956fe1 into 1.13.0 Feb 10, 2021
@ghost ghost deleted the performance-db-access-in-ut branch February 10, 2021 07:18
ghost pushed a commit that referenced this pull request Mar 24, 2021
@lucasborin
1.13.0 (#323)
702c43b 
* versioning

* Performance of DB Access in UT Check (#320)

* Update README.md

* disabling rfc

* Update changelog.txt

* Update changelog.txt

* 1.12.0

* Profile Tool - UX Refinement (#313)

Minor UX Changes

* Update changelog.txt

* Update changelog.txt

* Performance (#317)

* buffer size

* fixing dump when object is not supported by sci

* solving dump when ref scan is not set

* Update y_ref_scan_manager.clas.abap

* Update changelog.txt

* removing shared memory (#319)

* Update changelog.txt

* Performance Improvements (#318)

* moving application component valid. to ref_scan

* wip

* changing validation sequence

* fixing minor bug

* fixing bug

* refactoring former buffer

* syntax error

* fixing ut

* fixing unit test base

* abaplint hint

* Update changelog.txt

* wip

* minor update

* minor change

* Code review (#322)

* removing unused exception

* solving empty catch

* moving buffer cleanup

* pretty printer

* Update y_code_pal_version.intf.abap

* commented changes

Co-authored-by: Eugen Günther <64586309+eugen-guenther-sap@users.noreply.github.com>
Co-authored-by: Eugen Guenther <eugen.guenther@sap.com>

* minor change

* Update changelog.txt

Co-authored-by: Eugen Günther <64586309+eugen-guenther-sap@users.noreply.github.com>
Co-authored-by: Eugen Guenther <eugen.guenther@sap.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@lucasborin lucasborin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Performance of the check: "DB in UT"
3 participants
@lucasborin @larshp @estevao-schultz-neto-SAP