Bump hyperscan dep #282
Merged
Bump hyperscan dep #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2023
|
Tests failing for python3.9 as it's wheels are missing (and also sdist is missing) |
|
Using hyperscan v0.5.0 only for python3.9 version In addition, as |
marcorosa
commented
Nov 23, 2023
.github/workflows/test.yml
Outdated
Comment on lines
56
to
60
| - name: Install python dependencies | ||
| run: | | ||
| pip install -r ./requirements.txt | ||
| pip install -r ./tests/tests-requirements.txt | ||
|
|
There was a problem hiding this comment.
tests requirements need to be reintroduced otherwise tests will fail due to missing deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump hyperscan dependency.
hyperscan v0.6 should work seamlessly on all python versions and should not require any hyperscan package to be installed upfront on the OS -> TODO: update README and Docker container image