fix(platform): colon when no description is present for popping colum…

…ns (#12981) * fix(platform): aria-label for vhd clear button * fix(platform): colon when no description is present for popping columns --------- Co-authored-by: deno <mladen.droshev@sap.com>
SAP · Feb 4, 2025 · 7bc90e0 · 7bc90e0
1 parent dd4612e
commit 7bc90e0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/libs/platform/table/components/table-popping-row/table-popping-row.component.html b/libs/platform/table/components/table-popping-row/table-popping-row.component.html
@@ -12,7 +12,9 @@
 >
     @for (poppingColumn of _fdpTableService.poppingColumns$(); track poppingColumn.name) {
         <div fd-table-text>
-            <label fd-form-label>{{ poppingColumn.label }}:</label>
+            @if (poppingColumn?.label?.length) {
+                <label fd-form-label>{{ poppingColumn.label }}:</label>
+            }
 
             @if (poppingColumn?.columnCellTemplate) {
                 <ng-template

diff --git a/libs/platform/value-help-dialog/value-help-dialog/value-help-dialog.component.html b/libs/platform/value-help-dialog/value-help-dialog/value-help-dialog.component.html
@@ -87,7 +87,7 @@
                                 fdType="transparent"
                                 [title]="'platformVHD.footerClearSelectedTitle' | fdTranslate"
                                 glyph="decline"
-                                [attr.aria-label]="'platformVHD.footerClearSelectedAriaLabel' | fdTranslate"
+                                [ariaLabel]="'platformVHD.footerClearSelectedAriaLabel' | fdTranslate"
                             ></button>
                         </div>
                     </div>